958993 - taping "Clear" button under "Options" several times creates multiple modal prompts

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

If a user taps the "Clear" button under the "Options" flyout, it will create multiple instances of the modal window. If a "Clear Private Data" modal window is already visible, pressing the "Clear" button again shouldn't be creating another instance on top of the older one.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Slide in the Windows Charm
3) Select "Settings" and than "Options"
4) Tap on the "Clear" button several times and you'll notice multiple instances of the modal window being created on top of each other

Current Behavior:

- Tapping on the "Create" button under the "Options" flyout creates multiple instances of the modal window

Expected Behavior:

- If a modal window is already visible, taping on "Clear" shouldn't be creating another instance on top of the older instance

Found the issue using the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-12-03-02-04-mozilla-central/

Comment 1

[Matt Brubeck (:mbrubeck)]

We could probably fix this by disabling the "clear" button when it's pressed and re-enabling it when the dialog closes.

Comment 2

[Allison Naaktgeboren :ally]

Attachment: clearDataBug_958993

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8361402 [details] [diff] [review]
clearDataBug_958993

Review of attachment 8361402 [details] [diff] [review]:
-----------------------------------------------------------------

woot! ship it!

Comment 4

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/fx-team/rev/8e84b3c20518

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8e84b3c20518

Comment 6

[Marco Mucci [:MarcoM]]

Temporarily reopening to add to Iteration #23 (Bug 961497)

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a673eac28120

Comment 8

[u279076]

Kamil, please verify this is fixed in the latest Nightly and Aurora builds.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following verification without any issues. Used the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-05-00-40-01-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-05-03-02-03-mozilla-central/

- Ensured that the "Clear private data" modal window appears when taping/clicking on "Clear"
- Ensured that taping/clicking on "Clear" correctly clears the data that was selecting under the "Options" flyout
- Ensured that taping/clicking on the "Cancel" button correctly dismisses the "Clear private data" modal without clearing any data
- Ensured that the "Clear" button is disabled while the "Clear private data" modal window is opened
- Ensured that while the modal window is opened, you cannot click/tap on anything in the background (links, images, scrolling etc..)
- Ensured that when both "Browsing history" and "Other Data" are deselected, the "Clear" button is disabled
- Ensured that all of the above test cases also worked under snapped view

Marking this issue as verified as the original problem of the "Clear" button not being disabled initially has been resolved. However, I found another case were this could happen and created the following issue: 
- Bug # 968534