959021 - [Media Encoder] Rename the HAS_AUDIO/HAS_VIDEO in ContainerWriter.h

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

The naming is bad, We should change it.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

also change the naming on this comment
https://bugzilla.mozilla.org/show_bug.cgi?id=961618#c2


I think you should rename EncodedFrame::SetFrameData() to SwapFrameData(), and
call:

nsTArray<uint8_t> frameData;
frames.ElementAt(i)->SwapFrameData(&frameData);
mControl->WriteAVData(frameData);

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: add_swap_av_frame

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Benjmin, 
Need your help to sync this patch to WebM muxer if got r+

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: add_swap_av_frame

Carry r+.

https://tbpl.mozilla.org/?tree=Try&rev=b89ca7fea3fb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5d61348f2589

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d61348f2589