959030 - PlacesBackups deprecation warning and potential hidden issues

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Richard Newman [:rnewman]]

yield PlacesBackups.create(null, true);

=>

DEPRECATION WARNING: PlacesBackups.entries is deprecated and will be removed in a future version
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695
resource://gre/modules/PlacesBackups.jsm 86 this.PlacesBackups.entries
resource://gre/modules/PlacesBackups.jsm 245 PB_saveBookmarksToJSONFile/<

DEPRECATION WARNING: PlacesBackups.folder is deprecated and will be removed in a future version
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695
resource://gre/modules/PlacesBackups.jsm 42 this.PlacesBackups.folder
resource://gre/modules/PlacesBackups.jsm 90 this.PlacesBackups.entries
resource://gre/modules/PlacesBackups.jsm 245 PB_saveBookmarksToJSONFile/<


from

      if (aFile.parent.path == backupFolderPath) {
        // Update internal cache.
        this.entries.push(aFile);


In the course of evaluating `this.entries`, two deprecation warnings are being triggered.

This certainly shouldn't be dumping deprecation warnings, and given that it is, there might be an actual coding error hiding here.

Comment 1

[Marco Bonardo [:mak]]

fixed by bug 824433