959035 - Don't send X-Confirm-Delete header to sync1.5 storage servers

Status: NEW

(Firefox :: Sync, defect, P5)

Description

[Ryan Kelly [:rfkelly]]

Per the proposed sync1.5 protocol docs in Bug 951986, the sync storage servers will no longer require an "X-Confirm-Delete" header on delete requests.  Desktop sync client should avoid sending this header if it knows it's talking to a sync1.5 server.

Note that it's safe to send the header anyway if you need to, as it will be ignored.

Comment 1

[Richard Newman [:rnewman]]

N.B., given that the backend client code is shared, this removal either needs to be conditional or to only occur when Sync 1.1 is deprecated.

Comment 2

[Ryan Kelly [:rfkelly]]

I'm tempted to just WONTFIX this as it's such a tiny bug, but maybe we can move on it now that sync1.1 has been end-of-lifed?  We don't have an official policy on maintaining compatibility in client code, although in [1] I back-handedly suggest that we won't begin breaking it until 2016.

[1] https://blog.mozilla.org/services/2015/07/31/shutting-down-the-legacy-sync-service/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ryan Kelly [:rfkelly] from comment #2)
> I'm tempted to just WONTFIX this as it's such a tiny bug, but maybe we can
> move on it now that sync1.1 has been end-of-lifed?  We don't have an
> official policy on maintaining compatibility in client code, although in [1]
> I back-handedly suggest that we won't begin breaking it until 2016.

self-hosters remain a problem, so I don't think we can do it now. I don't see a problem keeping it open and fixing it some time next year though :)