959040 - [emulator][mochitest] Turn of WebRTC logging for emulator

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We've turned on WebRTC logging on TBPL for Firefox [1] and it'll be nice to have it turned on for Firefox OS.

[1] http://dxr.mozilla.org/mozilla-central/source/build/automation.py.in#514

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: webrtc-logging-emulator.patch

I can turn on WebRTC logging with this simple patch but I'm not sure if we need a more general way of adding environment variable in B2GRunner.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8359058 [details] [diff] [review]
webrtc-logging-emulator.patch

Review of attachment 8359058 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine for me. Just be aware that this will turn it on for anything that uses mozrunner, not just mochitest. Is that what you wanted to do?

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Who else uses mozrunner? marionette? We definitely want to turn on WebRTC logging on all the test frameworks for now.

Comment 4

[Andrew Halberstadt [:ahal]]

Yeah I believe it's just marionette for now, but in the future more will. Yeah, I suspected this would be useful across all harnesses. So if this all that's needed, I'd r+. Note that mozbase lives in github: https://github.com/mozilla/mozbase (though we are in the process of bringing it into m-c) so you'll need to land it there first.

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: pull request

Carry r+ based on comment #4.

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://tbpl.mozilla.org/?tree=Try&rev=cb82181e704b

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I've create a pull request on github for this patch. Can you help merge it?

Comment 8

[Andrew Halberstadt [:ahal]]

Done. Thanks! I'll leave this open in case you wanted to land on mozilla-central too.

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8359058 [details] [diff] [review]
webrtc-logging-emulator.patch

@ahal, sure I want this patch on m-c as well. Is adding "check-in needed" like other gecko patch enough for doing so?

Comment 10

[Andrew Halberstadt [:ahal]]

On irc we talked, this isn't urgent. So I'll land this on m-c when the next (and last!) mozbase merge happens.