959043 - [Gaia]Software home button is gone

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: software-home-button.mp4

When rotating the nexus 4 from portrait to landscape and back to portrait, the software home button disappeared and no way to go back to home screen.

STR:
1. open a fullscreen app that its orientation should not be locked, like: gallyer, video, etc.
2. rotate the phone to landscape <== software home button is gone.
3. rotate the phone to portrait <== gone again.

Version:
Master: 20140112040202
Device: Nexus 4

Comment 1

[Eric Chou [:ericchou] [:echou]]

Quick note: I can reproduce as well via the different STR.

Prerequisite:
A nexus 4 with software home button enabled. At least a photo in the storage.

STR:
(1) Launch Gallery app
(2) Choose a photo and click
(3) Click the share button
(4) Choose 'Wallpaper'

Result:
software home button disappears.

Note:
After step (4), you can click the camera icon to go back to Camera app, and you'll see the home key appears again, however nothing happens when click on it.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #1)
> Note:
> After step (4), you can click the camera icon to go back to Camera app, and
> you'll see the home key appears again, however nothing happens when click on
> it.

The same symptom can be observed with the STR at description.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Bad, on it :/

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15346

This patch:
1. Fix fullscreen app size when software home button is there
2. Fix keyboard manager hideImmediately to avoid the redundant resizing when activity is opening/closing
3. Fix unit tests

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8360281 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15346

r=me, keyboard_manager part.
Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8360281 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15346

Thank you for keeping non-shipping feature alive :)

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Travis is green.
https://github.com/mozilla-b2g/gaia/commit/21166231ed393fec82c337eaba5c98fd300ef5cb