[NFC] rotating of shrink UI is wrong.

RESOLVED FIXED in 2.0 S1 (9may)

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: johnhu, Assigned: gasolin)

Tracking

unspecified
2.0 S1 (9may)
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [priority][p=1])

Attachments

(3 attachments)

STR:
1. touch two device
2. rotate the phone <== the shrinking UI shows wrong image.

As we discuss with UX offline, the rotation should be disabled in this case.
Blocks: b2g-NFC-2.0
Blocks: NFC-Gaia
No longer blocks: b2g-NFC-2.0
Hi Peter, 
This is key focus feature in 1.5. Could you put into browser's backlog?
Flags: needinfo?(pdolanjski)
My bad. This one is not for browser.
Flags: needinfo?(pdolanjski)
This issue is caused by we screenshoting the app as the sliding image, and the screenshot won't follow app to do rotation. I just confirm this with John that Alive has said that we should ban the rotation during NFC sharing (which is weird and a edge case) to solve this issue. But I'll confirm this with UX and post the conclusion here.
Hope this bug can be fixed before 5/9.
Target Milestone: --- → 1.5 S1 (9may)
Assignee: nobody → gweng
blocking-b2g: --- → 2.0?
Wesley,

Is this NFC bug needed for v2.0
Flags: needinfo?(whuang)
YES, as NFC p2p sharing is key focus in 2.0.
ni? to Juwei to decide whether we should ban the rotation for shrinking UI.
Flags: needinfo?(whuang) → needinfo?(jhuang)
Once the two devices paired, the rotation should be DISABLE when screen orientation changed otherwise the display UI would cause error image.
Flags: needinfo?(jhuang)
blocking-b2g: 2.0? → backlog
Whiteboard: [priority]
This bug blocks NFC 2.0 release.
Blocks: b2g-NFC-2.0
take it
Assignee: gweng → gasolin
tested on real device
Attachment #8419231 - Flags: review?(alive)
Comment on attachment 8419231 [details] [review]
pull request redirect to github

commented
Attachment #8419231 - Flags: review?(alive)
Comment on attachment 8419231 [details] [review]
pull request redirect to github

revised and tested in browser(orient:no default) and music(orient:default) app.

after shrink-stop music app's orientation won't be unlocked.
Attachment #8419231 - Flags: review?(alive)
Attachment #8419231 - Flags: review?(alive) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/c859fc43c23713844239a13172ca7e6b0c94cbcb

thanks!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [priority] → [priority][p=1]
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.