959091 - duplicated textures in one frame when using LayerScope

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Peter Chang[:pchang]]

Attachment: Frame with duplicated textures

Please refer to attached image file and you could see the duplicated texture with id "102".

Comment 1

[Peter Chang[:pchang]]

The 'id' is actually the texture id.

The reason why I saw the duplicated texture id was caused by one compositible layer has multiple visible regions, like the following log pattern.

There are two visible regions for ThebesLayerComposite.

I/Gecko   (21542): peter ThebesLayerComposite 0x44d35800 RenderLayer
I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect 2 tileScreenRect (0 0 320 385)
I/Gecko   (21542): peter SendTextureSource textureid 5
I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect 2 tileScreenRect (0 459 1 1)
I/Gecko   (21542): peter SendTextureSource textureid 5

Comment 2

[u459114]

(In reply to peter chang[:pchang][:peter] from comment #1)
> The 'id' is actually the texture id.
> 
> The reason why I saw the duplicated texture id was caused by one
> compositible layer has multiple visible regions, like the following log
> pattern.
> 
> There are two visible regions for ThebesLayerComposite.
> 
> I/Gecko   (21542): peter ThebesLayerComposite 0x44d35800 RenderLayer
> I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect
> 2 tileScreenRect (0 0 320 385)
> I/Gecko   (21542): peter SendTextureSource textureid 5
> I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect
> 2 tileScreenRect (0 459 1 1)
> I/Gecko   (21542): peter SendTextureSource textureid 5
Should we filter out those duplicate textures at device side?

Comment 3

[Peter Chang[:pchang]]

(In reply to C.J. Ku[:CJKu] from comment #2)
> (In reply to peter chang[:pchang][:peter] from comment #1)
> > The 'id' is actually the texture id.
> > 
> > The reason why I saw the duplicated texture id was caused by one
> > compositible layer has multiple visible regions, like the following log
> > pattern.
> > 
> > There are two visible regions for ThebesLayerComposite.
> > 
> > I/Gecko   (21542): peter ThebesLayerComposite 0x44d35800 RenderLayer
> > I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect
> > 2 tileScreenRect (0 0 320 385)
> > I/Gecko   (21542): peter SendTextureSource textureid 5
> > I/Gecko   (21542): peter content(0x436b1e50) DrawQuad532 x 0 y 0 regionRect
> > 2 tileScreenRect (0 459 1 1)
> > I/Gecko   (21542): peter SendTextureSource textureid 5
> Should we filter out those duplicate textures at device side?

Actually it doesn't mean there are duplicated texture.s
It means compositor tried to use the same texture to draw different regions, like (0,0,320,385) and 0, 459, 1, 1).

The last region is a little strange for me, checking...

Comment 4

[Peter Chang[:pchang]]

BTW, we could add the visible regions for each texture into LayerScope.

Comment 5

[u459114]

(In reply to peter chang[:pchang][:peter] from comment #4)
> BTW, we could add the visible regions for each texture into LayerScope.

Yes, and we should not fetch identical textures from device to save  socket bandwidth

Comment 6

[Peter Chang[:pchang]]

Based on comment 3, this bug is not a issue now. Close case.