959131 - vendor-local is missing unidecode

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Andrei Hajdukewycz [:sancus]]

This apparently isn't installed on dev/stage and so presumably it's not on production either. That means it needs to be in a vendor dir.

Not sure how this wasn't caught before, other projects that use unidecode(ie remo) do have it in their vendor-local.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d4b37aeea337f35c5a4ae660dcda38bdf6538e8f
[Fix Bug 959131] Add unidecode 0.4.14 to vendor-local/lib

Comment 2

[Matt Brandt [:mbrandt]]

Is this [qa-]?

Comment 3

[Giorgos Logiotatidis [:giorgos]]

unidecode wasn't a required library up until now. It's a suggested library, something AutoSlug will use if it's present. Recent changes made it a required library.

Thanks for fixing that :sancus.

@mbrandt yes we can call this qa-

Comment 4

[Andrei Hajdukewycz [:sancus]]

Ah, I didn't realize autoslug used it optionally. Well either way, fixed now. And yep, definitely qa-.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/ead755adfd5bcd498434ac622b5a0d3ae0e0bd23
Bug 959131 - Make unidecode a git submodule

Comment 6

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-]