Search Results Overlay Minimum Results has Two Blank Tiles

VERIFIED FIXED in Firefox 28

Status

Firefox for Metro
General
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: shorlander, Assigned: rsilveira)

Tracking

Trunk
Firefox 29

Firefox Tracking Flags

(firefox28 verified, firefox29 verified)

Details

(Whiteboard: [beta28] [defect] p=1)

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
Not sure if this is intentional but if you only have one search result you end up with two placeholder tiles that you can't click.

Updated

4 years ago
Blocks: 838081
Whiteboard: [triage] [defect] p=0

Updated

4 years ago
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Created attachment 8359523 [details] [diff] [review]
959147.patch

By default we have 3 empty slots for new grids, which includes the search results grid. They were hidden by default, but the fix for bug 941284 regressed this, making the search empty slots visible.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #8359523 - Flags: review?(sfoster)
p=1

Updated

4 years ago
Blocks: 955892
No longer blocks: 838081
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [release28] [defect] p=0 → [beta28] [defect] p=1
Comment on attachment 8359523 [details] [diff] [review]
959147.patch

Review of attachment 8359523 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.
Attachment #8359523 - Flags: review?(sfoster) → review+
https://hg.mozilla.org/integration/fx-team/rev/6f92e4a555b1
https://hg.mozilla.org/mozilla-central/rev/6f92e4a555b1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Please give some guidance in order for the QA to verify this. Thanks!
Flags: needinfo?(rsilveira)
For QA: Without the patch when you type on the url bar and autocomplete has only one result, 3 tiles would show up. 2 of them blank. With this fix only the result tile shows up. To test this type in the name of a site that has only 1 entry in bookmarks/history.
Flags: needinfo?(rsilveira)
Whiteboard: [beta28] [defect] p=1 → [beta28] [defect] p=1 [approval-mozilla-aurora=metro-only]
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/509aafb4f3b2
status-firefox28: --- → fixed
status-firefox29: --- → fixed
Keywords: checkin-needed
Whiteboard: [beta28] [defect] p=1 [approval-mozilla-aurora=metro-only] → [beta28] [defect] p=1
Created attachment 8363527 [details]
screenshot.png

>For QA: Without the patch when you type on the url bar and autocomplete has only >one result, 3 tiles would show up. 2 of them blank. With this fix only the result >tile shows up. To test this type in the name of a site that has only 1 entry in >bookmarks/history.

With a new profile and latest Nightly on Win 8 64-bit, I can see 3 tiles showing up for a site that has only 1 entry in History section. (please see the attached screenshot for details)

Any suggestions?
Flags: needinfo?(rsilveira)
The screenshot seem to show 3 actual results. You can type 'involved' on a brand new profile. It should show you only the 'get involved' default bookmark tile. The bug was about showing empty tiles when you had less than 3 results, if you're seeing clickable tiles it's expected.
Flags: needinfo?(rsilveira)
Created attachment 8364223 [details]
screenshots.zip

Please see the attached screenshots:

- on Win 8 64-bit with latest Nightly and a new profile:

1) "nightly_first search.png" shows the results of the first search performed

2) "nightly_second search.png" shows the results of the second, third, etc. searches performed

Is this intended?
Flags: needinfo?(rsilveira)
Created attachment 8365206 [details]
Autocomplete1Result.png

This is what I'm seeing. I think the two results you're seeing are because once you visit the default bookmarked site you may get redirected and end up with a another match for "involved" in your history :(. One last think you can try is visiting a site with an odd name like http://9gag.com, then search for 9gag and you should see a single history entry.
Flags: needinfo?(rsilveira)
Keywords: verifyme
> One last think you can try is visiting a site with an odd name like http://9gag.com, then
> search for 9gag and you should see a single history entry.

Yes, indeed, this works. Verified as fixed, for iteration #22, with latest Nightly and Aurora on Win 8 64-bit.
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.