Closed Bug 959147 Opened 6 years ago Closed 6 years ago

Search Results Overlay Minimum Results has Two Blank Tiles

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

defect

Tracking

(firefox28 verified, firefox29 verified)

VERIFIED FIXED
Firefox 29
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: shorlander, Assigned: rsilveira)

References

Details

(Whiteboard: [beta28] [defect] p=1)

Attachments

(4 files)

Not sure if this is intentional but if you only have one search result you end up with two placeholder tiles that you can't click.
Whiteboard: [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Attached patch 959147.patchSplinter Review
By default we have 3 empty slots for new grids, which includes the search results grid. They were hidden by default, but the fix for bug 941284 regressed this, making the search empty slots visible.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #8359523 - Flags: review?(sfoster)
Blocks: metrov1it22
No longer blocks: metrov1backlog
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [release28] [defect] p=0 → [beta28] [defect] p=1
Comment on attachment 8359523 [details] [diff] [review]
959147.patch

Review of attachment 8359523 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.
Attachment #8359523 - Flags: review?(sfoster) → review+
https://hg.mozilla.org/mozilla-central/rev/6f92e4a555b1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Please give some guidance in order for the QA to verify this. Thanks!
Flags: needinfo?(rsilveira)
For QA: Without the patch when you type on the url bar and autocomplete has only one result, 3 tiles would show up. 2 of them blank. With this fix only the result tile shows up. To test this type in the name of a site that has only 1 entry in bookmarks/history.
Flags: needinfo?(rsilveira)
Whiteboard: [beta28] [defect] p=1 → [beta28] [defect] p=1 [approval-mozilla-aurora=metro-only]
https://hg.mozilla.org/releases/mozilla-aurora/rev/509aafb4f3b2
Keywords: checkin-needed
Whiteboard: [beta28] [defect] p=1 [approval-mozilla-aurora=metro-only] → [beta28] [defect] p=1
Attached image screenshot.png
>For QA: Without the patch when you type on the url bar and autocomplete has only >one result, 3 tiles would show up. 2 of them blank. With this fix only the result >tile shows up. To test this type in the name of a site that has only 1 entry in >bookmarks/history.

With a new profile and latest Nightly on Win 8 64-bit, I can see 3 tiles showing up for a site that has only 1 entry in History section. (please see the attached screenshot for details)

Any suggestions?
Flags: needinfo?(rsilveira)
The screenshot seem to show 3 actual results. You can type 'involved' on a brand new profile. It should show you only the 'get involved' default bookmark tile. The bug was about showing empty tiles when you had less than 3 results, if you're seeing clickable tiles it's expected.
Flags: needinfo?(rsilveira)
Attached file screenshots.zip
Please see the attached screenshots:

- on Win 8 64-bit with latest Nightly and a new profile:

1) "nightly_first search.png" shows the results of the first search performed

2) "nightly_second search.png" shows the results of the second, third, etc. searches performed

Is this intended?
Flags: needinfo?(rsilveira)
Attached image Autocomplete1Result.png
This is what I'm seeing. I think the two results you're seeing are because once you visit the default bookmarked site you may get redirected and end up with a another match for "involved" in your history :(. One last think you can try is visiting a site with an odd name like http://9gag.com, then search for 9gag and you should see a single history entry.
Flags: needinfo?(rsilveira)
> One last think you can try is visiting a site with an odd name like http://9gag.com, then
> search for 9gag and you should see a single history entry.

Yes, indeed, this works. Verified as fixed, for iteration #22, with latest Nightly and Aurora on Win 8 64-bit.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.