959157 - Moz2Dify GLReadTexImageHelper

Status: UNCONFIRMED

(Core :: Graphics, defect)

Description

[Andreas Pehrson [:pehrsons]]

Used to be a part of GLContext, but bug 877115 is getting bloated by comments and patches so let's break distinguishable parts out of it.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Part 1. Remove GLReadTexImageHelper::ReadPixelsIntoImageSurface.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8402411 [details] [diff] [review]
Part 1. Remove GLReadTexImageHelper::ReadPixelsIntoImageSurface.

Review of attachment 8402411 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.cpp
@@ +654,5 @@
>      bool srcPremultAlpha = mOptions.premultipliedAlpha;
>      bool dstPremultAlpha = aFlags & RenderFlagPremultAlpha;
>  
>      if (!srcPremultAlpha && dstPremultAlpha) {
>          gfxUtils::PremultiplyImageSurface(surf);

The changes above move us in the right direction, but it'd be nice to port these functions to moz2d as part of this bug, perhaps in a later patch.