959185 - Audit API access levels in the toolbar package

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

We should be exposing API that is meant to be used outside the toolbar package.

Comment 1

[Alex Deaconu]

Hi, I am new to Fennec and I would like to start working on this, as a first issue. I have successfully build the project and I am using eclipse as an IDE. 

I would also need some additional feedback regarding the issue.

Thanks, 
Alex.

Comment 2

[Lucas Rocha (:lucasr)]

(In reply to Alex Deaconu from comment #1)
> Hi, I am new to Fennec and I would like to start working on this, as a first
> issue. I have successfully build the project and I am using eclipse as an
> IDE. 
> 
> I would also need some additional feedback regarding the issue.

This bug is pretty much about only exposing toolbar API when it's is strictly necessary. So, go through the classes, ensure all toolbar-specific methods, constants, etc are scoped correctly.

Most classes inheriting from Android API need to be public so that the Android framework has access to it. This is just about our own internal APIs.

Comment 3

[Alex Deaconu]

Attachment: changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Review of attachment 8409303 [details] [diff] [review]:
-----------------------------------------------------------------

Passing this request to Lucas.

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Review of attachment 8409303 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks! Please add checkin-needed keyword so that someone can push your patch.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

the keyword is the preferred method, iirc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0db08c20683d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Please just use checkin-needed in the future.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0db08c20683d