Closed Bug 959185 Opened 6 years ago Closed 6 years ago

Audit API access levels in the toolbar package

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: lucasr, Assigned: alexandru.deaconu)

References

Details

(Whiteboard: [good first bug][mentor=lucasr][lang=java])

Attachments

(1 file)

We should be exposing API that is meant to be used outside the toolbar package.
Whiteboard: [mentor=lucasr][lang=java]
Whiteboard: [mentor=lucasr][lang=java] → [good first bug][mentor=lucasr][lang=java]
Hi, I am new to Fennec and I would like to start working on this, as a first issue. I have successfully build the project and I am using eclipse as an IDE. 

I would also need some additional feedback regarding the issue.

Thanks, 
Alex.
Flags: needinfo?(lucasr.at.mozilla)
(In reply to Alex Deaconu from comment #1)
> Hi, I am new to Fennec and I would like to start working on this, as a first
> issue. I have successfully build the project and I am using eclipse as an
> IDE. 
> 
> I would also need some additional feedback regarding the issue.

This bug is pretty much about only exposing toolbar API when it's is strictly necessary. So, go through the classes, ensure all toolbar-specific methods, constants, etc are scoped correctly.

Most classes inheriting from Android API need to be public so that the Android framework has access to it. This is just about our own internal APIs.
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8409303 - Flags: review?(mbrubeck)
Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Review of attachment 8409303 [details] [diff] [review]:
-----------------------------------------------------------------

Passing this request to Lucas.
Attachment #8409303 - Flags: review?(mbrubeck) → review?(lucasr.at.mozilla)
Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Review of attachment 8409303 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks! Please add checkin-needed keyword so that someone can push your patch.
Attachment #8409303 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #8409303 - Flags: checkin?
the keyword is the preferred method, iirc
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/0db08c20683d
Assignee: nobody → alexandru.deaconu
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=lucasr][lang=java] → [good first bug][mentor=lucasr][lang=java][fixed-in-fx-team]
Comment on attachment 8409303 [details] [diff] [review]
changed access modifiers of methods and variables unused outside toolbar package from 'public' to 'default' or 'private'

Please just use checkin-needed in the future.
Attachment #8409303 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/0db08c20683d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=lucasr][lang=java][fixed-in-fx-team] → [good first bug][mentor=lucasr][lang=java]
Target Milestone: --- → Firefox 31
You need to log in before you can comment on or make changes to this bug.