959190 - URL objects lack proper stringification

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Claude Pache]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

Type in the console:

(new URL('http://example.com')) + ""



Actual results:

"[object URL]"


Expected results:

"http://example.com/"

Comment 1

[Claude Pache]

For reference:

http://url.spec.whatwg.org/#api

URLUtils and URLUtilsReadonly interfaces use the `href` attribute as stringifier.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And our WebIDL has the stringifier on it ... do stringifiers not work?  or do they not carry across implements statements?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Andrea, did you miss this in bug 887364?  Or has the spec changed since then?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> do stringifiers not work? 

Stringifier _attributes_ do not work so far in our WebIDL implementation.  See bug 851891 for making it a build-time error to try using one.

We should be using an anonymous stringifier method here.

Comment 5

[Boris Zbarsky [:bzbarsky]]

And add a test!

Comment 6

[Boris Zbarsky [:bzbarsky]]

And see bug 824857 for adding support for stringifier attributes.

Comment 7

[Andrea Marchesini [:baku]]

(In reply to Boris Zbarsky [:bz] from comment #3)
> Andrea, did you miss this in bug 887364?  Or has the spec changed since then?

I think the spec is changed. I don't remember. But it's doesn't really matter. I'm going to fix it asap.

Comment 8

[Andrea Marchesini [:baku]]

Attachment: url.patch

I removed 'stringify' in any webidl interface inheriting URLUtils.

Comment 9

[Andrea Marchesini [:baku]]

Attachment: url.patch

test for any stringify interface.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8359261 [details] [diff] [review]
url.patch

r=me.  Thank you for doing this!

Comment 11

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2f3827a2f44

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2f3827a2f44

Comment 13

[Florin Nechita]

[testday-20140411]
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

This issue is fixed on Windows 7 SP1 x64, using the latest Beta (20140410150427).