Closed
Bug 959197
Opened 12 years ago
Closed 12 years ago
Update gaia-ui-tests to use platformName instead of platform
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: automatedtester, Assigned: automatedtester)
References
Details
Attachments
(1 file)
The following will need to updated
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L680
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8361903 -
Flags: review?(dave.hunt)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8361903 [details] [review]
update platform to platformName
Looks fine. I've not run the tests myself, but triggered an adhoc build. As long as this doesn't show any unexpected failures, we should be good to merge.
http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui.adhoc/111/
Attachment #8361903 -
Flags: review?(dave.hunt) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
There are a few failures here but his patch should either break everything or nothing.
Dave, what are your thoughts on http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui.adhoc/120/
Flags: needinfo?(dave.hunt)
|
|
||
Comment 4•12 years ago
|
||
These do not appear to be related to your change, so I've gone ahead and landed it:
https://github.com/mozilla-b2g/gaia/commit/d9f00667af6e22f5bd42db68852c3f9a0011e3f8
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(dave.hunt)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•