959219 - Rename assertCurrentPage to assertCurrentPanel in AboutHomeComponent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Missed this one on the mass-renaming patch from bug 958185.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Rename assertCurrentPage to assertCurrentPanel (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8360343 [details] [diff] [review]
Rename assertCurrentPage to assertCurrentPanel (r=mcomella)

Review of attachment 8360343 [details] [diff] [review]:
-----------------------------------------------------------------

The match the latest terminology used in our about:home code. The big renaming patch is in bug 958185. I missed this one instance of 'page' in our code.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8360343 [details] [diff] [review]
Rename assertCurrentPage to assertCurrentPanel (r=mcomella)

Review of attachment 8360343 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ argument rename.

::: mobile/android/base/tests/components/AboutHomeComponent.java
@@ +61,5 @@
>      private ViewPager getHomePagerView() {
>          return (ViewPager) mSolo.getView(R.id.home_pager);
>      }
>  
> +    public AboutHomeComponent assertCurrentPanel(final PanelType expectedPage) {

expectedPage => expectedPanel

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Actually, we're also misssing certain method calls, e.g. `swipeToPage`, and enums, e.g. `PhonePage`. Do you mind hitting these too?

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Rename 'page' terminology to 'panel' in AboutHomeComponent (r=mcomella)

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8364464 [details] [diff] [review]
Rename 'page' terminology to 'panel' in AboutHomeComponent (r=mcomella)

(In reply to Michael Comella (:mcomella) from comment #5)
> Actually, we're also misssing certain method calls, e.g. `swipeToPage`, and
> enums, e.g. `PhonePage`. Do you mind hitting these too?

Nice catch, Here's a more thorough patch.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8364464 [details] [diff] [review]
Rename 'page' terminology to 'panel' in AboutHomeComponent (r=mcomella)

Review of attachment 8364464 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 9

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/1d2fa2d09f5b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d2fa2d09f5b