959379 - App icon in the launcher is fuzzy

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The app icon in the launcher of HTC One is fuzzy. It's a XHDPI device. So, the launcher takes the icon from XXHDPI folder.

Oh wait, S4 is a XXHDPI folder. So, it would need a XXXHDPI folder. The code base lacks both these folders.

Comment 1

[Ian Barlow (:ibarlow)]

Sriram!

Can I get some guidance on the app icon sizes we need here?

Comment 2

[Ian Barlow (:ibarlow)]

Hm so I did some digging, and it sounds like 144x144 is the XXHDPI size we want. And I have already made these and they should be in the app. So... What's the deal here? Do we need any even bigger size?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's check inside the APK to see if the XXHDPI icon.png is there. Maybe we are not putting the icon into the APK.

Comment 4

[Ian Barlow (:ibarlow)]

Cool. Meanwhile here they are again, in case we need them http://cl.ly/0i433o1p2E0q

Comment 5

[Richard Newman [:rnewman]]

Icons aren't fuzzy on my HTC One M7 (Sense, KitKat). Our APK contains a 144x144 icon.png in drawable-xxhdpi.

Apparently the Google Experience Launcher in KitKat uses xxxhdpi on xxhdpi devices (e.g., Nexus 5) for launcher icons, but the HTC One isn't in that set, because Sense.

xxxhdpi launcher icons are 192x192. Kindle Fire wants 675x675.

That assets zip, Ian, contains 144x144 and 512x512. Do you have a pre-sized icon for 192x192?

192x192 should be about 36KB. Do we 40KB-want this?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #5)

> 192x192 should be about 36KB. Do we 40KB-want this?

Yes

Comment 7

[Ian Barlow (:ibarlow)]

192x192 icons: http://cl.ly/2N3N3g2d3h1F

Comment 8

[:Margaret Leibovic]

Are we going to want to support xxhdpi icons for all the other resources in the app? That would probably be a lot of work, but maybe we should choose a few choice icons to start with? Out of scope of this bug, but related.

Comment 9

[Ian Barlow (:ibarlow)]

(In reply to :Margaret Leibovic from comment #8)
> Are we going to want to support xxhdpi icons for all the other resources in
> the app? That would probably be a lot of work, but maybe we should choose a
> few choice icons to start with? Out of scope of this bug, but related.

Yeah, we probably should start thinking about that. Bah.

Comment 10

[Richard Newman [:rnewman]]

Ian, can I get a Fennec head, 192x192? Comment 7 only has the three official channels.

Comment 11

[Richard Newman [:rnewman]]

s/three/four.

Comment 12

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/1865029d7205

Comment 13

[Richard Newman [:rnewman]]

I landed without unofficial. We'll see how this works when it reaches Nightly!

Comment 14

[Ian Barlow (:ibarlow)]

Thanks Richard. To be honest itll take some digging to even find that old fennec icon file, heh

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1865029d7205

Comment 16

[Richard Newman [:rnewman]]

AaronMT reports that this isn't fixed.

Both files are in the APK:

res/drawable-xxxhdpi/icon.png: PNG image data, 192 x 192, 8-bit/color RGBA, non-interlaced
res/drawable-xxhdpi/icon.png: PNG image data, 144 x 144, 8-bit/color RGBA, non-interlaced

so it looks like we're hitting:

https://code.google.com/p/android/issues/detail?id=63022

I'm pretty sure we don't want to yank xxhdpi, so we might just have to suffer this. Anyone have a different opinion?

Comment 17

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

(In reply to Richard Newman [:rnewman] from comment #16)
> AaronMT reports that this isn't fixed.

I didn't even know we had a problem?

The Nightly icon on my Nexus 5 (Android 4.4.4, GEL) looks fine to me.

Comment 18

[Richard Newman [:rnewman]]

Then great!

See Comment 5 for the bug this fixed.