App icon in the launcher is fuzzy

VERIFIED FIXED in Firefox 33

Status

()

VERIFIED FIXED
5 years ago
2 years ago

People

(Reporter: sriram, Assigned: rnewman)

Tracking

unspecified
Firefox 33
All
Android
Points:
---

Firefox Tracking Flags

(fennec+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The app icon in the launcher of HTC One is fuzzy. It's a XHDPI device. So, the launcher takes the icon from XXHDPI folder.

Oh wait, S4 is a XXHDPI folder. So, it would need a XXXHDPI folder. The code base lacks both these folders.
tracking-fennec: --- → ?
Sriram!

Can I get some guidance on the app icon sizes we need here?
Hm so I did some digging, and it sounds like 144x144 is the XXHDPI size we want. And I have already made these and they should be in the app. So... What's the deal here? Do we need any even bigger size?
Let's check inside the APK to see if the XXHDPI icon.png is there. Maybe we are not putting the icon into the APK.
Cool. Meanwhile here they are again, in case we need them http://cl.ly/0i433o1p2E0q
tracking-fennec: ? → +
(Assignee)

Updated

4 years ago
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Hardware: ARM → All
(Assignee)

Comment 5

4 years ago
Icons aren't fuzzy on my HTC One M7 (Sense, KitKat). Our APK contains a 144x144 icon.png in drawable-xxhdpi.

Apparently the Google Experience Launcher in KitKat uses xxxhdpi on xxhdpi devices (e.g., Nexus 5) for launcher icons, but the HTC One isn't in that set, because Sense.

xxxhdpi launcher icons are 192x192. Kindle Fire wants 675x675.

That assets zip, Ian, contains 144x144 and 512x512. Do you have a pre-sized icon for 192x192?

192x192 should be about 36KB. Do we 40KB-want this?
Flags: needinfo?(ibarlow)
(In reply to Richard Newman [:rnewman] from comment #5)

> 192x192 should be about 36KB. Do we 40KB-want this?

Yes
192x192 icons: http://cl.ly/2N3N3g2d3h1F
Flags: needinfo?(ibarlow)

Comment 8

4 years ago
Are we going to want to support xxhdpi icons for all the other resources in the app? That would probably be a lot of work, but maybe we should choose a few choice icons to start with? Out of scope of this bug, but related.
(In reply to :Margaret Leibovic from comment #8)
> Are we going to want to support xxhdpi icons for all the other resources in
> the app? That would probably be a lot of work, but maybe we should choose a
> few choice icons to start with? Out of scope of this bug, but related.

Yeah, we probably should start thinking about that. Bah.
(Assignee)

Comment 10

4 years ago
Ian, can I get a Fennec head, 192x192? Comment 7 only has the three official channels.
(Assignee)

Comment 11

4 years ago
s/three/four.
(Assignee)

Comment 13

4 years ago
I landed without unofficial. We'll see how this works when it reaches Nightly!
Component: General → Theme and Visual Design
Thanks Richard. To be honest itll take some digging to even find that old fennec icon file, heh
https://hg.mozilla.org/mozilla-central/rev/1865029d7205
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
(Assignee)

Comment 16

4 years ago
AaronMT reports that this isn't fixed.

Both files are in the APK:

res/drawable-xxxhdpi/icon.png: PNG image data, 192 x 192, 8-bit/color RGBA, non-interlaced
res/drawable-xxhdpi/icon.png: PNG image data, 144 x 144, 8-bit/color RGBA, non-interlaced

so it looks like we're hitting:

https://code.google.com/p/android/issues/detail?id=63022

I'm pretty sure we don't want to yank xxhdpi, so we might just have to suffer this. Anyone have a different opinion?
Created attachment 8456533 [details]
screenshot.png

(In reply to Richard Newman [:rnewman] from comment #16)
> AaronMT reports that this isn't fixed.

I didn't even know we had a problem?

The Nightly icon on my Nexus 5 (Android 4.4.4, GEL) looks fine to me.
(Assignee)

Comment 18

4 years ago
Then great!

See Comment 5 for the bug this fixed.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

4 years ago
Blocks: 1104366
You need to log in before you can comment on or make changes to this bug.