Closed Bug 959396 Opened 6 years ago Closed 6 years ago
Fx sometimes gets into state where the pref "browser .sessionstore .resume _session _once" is stuck to "true"
The pref "browser.sessionstore.resume_session_once" sometimes gets stuck to "true," causing metroFx to always restore its previous session.
Whiteboard: [triage] → [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [beta28] [defect] p=0
Whiteboard: [beta28] [defect] p=0 → [beta28] [defect] p=3
So it turns out we were initializing WindowsPrefSync after we were setting resume_session_once to false here: http://dxr.mozilla.org/mozilla-central/source/browser/metro/components/SessionStore.js#137 This meant the registry entry for resume_session_once was not updated to false and stuck as true. After doing this, I also noticed I was getting the issue you came across before, Tim, where the sessionstore.js file was not written correctly. This was something I missed when I did bug 950159 related to setting the _orderedWindows property even when we are not restoring.
Assignee: nobody → msamuel
Status: NEW → ASSIGNED
Attachment #8362752 - Flags: review?(tabraldes)
Oops that last patch was not up to date.
Comment on attachment 8362770 [details] [diff] [review] v2: Init WindowsPrefSync sooner and check populate _orderedWindows even when not restoring Review of attachment 8362770 [details] [diff] [review]: ----------------------------------------------------------------- LGTM though I haven't tested the fix locally
Attachment #8362770 - Flags: review?(tabraldes) → review+
Whiteboard: [beta28] [defect] p=3 → [fixed-in-fx-team][beta28] [defect] p=3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][beta28] [defect] p=3 → [beta28] [defect] p=3
Target Milestone: --- → Firefox 29
Whiteboard: [beta28] [defect] p=3 → [beta28] [defect] [a=metro-only] p=3
Kamil, can you please try to verify this is fixed in the latest Nightly and Aurora?
Verified as fixed, for iteration #23, with both latest Nightly and Aurora on Win 8.1 64-bit: the pref "browser.sessionstore.resume_session_once" doesn't get stuck to "true," .
You need to log in before you can comment on or make changes to this bug.