959423 - OpenH264: Assertion failed: (*ppPic1 != *ppPic2) [@WelsSVCEnc::WelsExchangeSpatialPictures]

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

codec/encoder/./core/src/picture_handle.cpp:178

  void WelsExchangeSpatialPictures (SPicture** ppPic1, SPicture** ppPic2) {
    SPicture* tmp = *ppPic1;

*   assert (*ppPic1 != *ppPic2);

    *ppPic1 = *ppPic2;
    *ppPic2 = tmp;
  }

To reproduce do:

    ./h264enc welsenc_fuzz.cfg

Tested with https://github.com/cisco/openh264/commit/301b06a

Comment 1

[Christoph Diehl [:posidron]]

Attachment: welsenc_fuzz.cfg

Comment 2

[Christoph Diehl [:posidron]]

Attachment: layer_fuzz.cfg

Comment 3

[karina]

we can reproduce this issue. and is working on it.

Comment 4

[karina]

Hi Christoph:
   fix it. Could you verify it on cisco/master branch? thanks!

Comment 5

[Christoph Diehl [:posidron]]

Fixed.

Tested with https://github.com/cisco/openh264/commit/de935a523