959447 - Remove twittershare test app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Apparently the twittershare test app is no longer useful according to Francisco (see bug 958740 comment 4) and is "deprecated since twitter exposed their own web activity to perform the share".

Shall we remove it? This will fix bug 958739 and bug 958740.

Not sure who should take this - so setting needinfo? from Tim.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Agree with the removal if there the app is unsupported.

I have no opinion on who should take this issue. Maybe this is a good first bug?

Comment 2

[Larry Xiao]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #1)
> Agree with the removal if there the app is unsupported.
> 
> I have no opinion on who should take this issue. Maybe this is a good first
> bug?

Hi Gary, Tim!
I'd like to work on it! as my first bug fixes =D
I'm currently trying to build B2G, not familiar with the code base yet.
But I'll pick it up quickly.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Xiaodi,

Glad to hear that! You are now being set as the assignee of the bug.

Please set-up your Gaia development by looking at the following documentation.

https://github.com/mozilla-b2g/gaia/blob/master/README.md
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

+1 to remove them :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

I mean remove it.

Comment 6

[Larry Xiao]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15365

Comment 7

[Larry Xiao]

Comment on attachment 8360472 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15365

following the documentation,
- I cloned mozilla-central to build firefox
- and cloned Gaia and DEBUG=1 make to build debug-profile
- (used Gaia in Firefox)

then I removed showcase_apps/twittershare entry in apps-engineering.list
and showcase_apps/twittershare itself
since this is an app, manual test is done (hope it's working)

(I worked from forked git repo of https://github.com/mozilla-b2g/gaia.git, and created a pull request there, and a review request on bugzilla)

it's an amazing project! and this is fun!
thank you!

Comment 8

[Larry Xiao]

if "deprecated since twitter exposed their own web activity to perform the share"
what's the right thing to do then?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8360472 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15365

Great! Thank you for the pull request and a clear description on what's being done.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to xiaodi from comment #8)
> if "deprecated since twitter exposed their own web activity to perform the
> share"
> what's the right thing to do then?

The Twitter app itself now works with FxOS; people could share pictures from that.

I have merged the pull request with the merge commit below:
master: https://github.com/mozilla-b2g/gaia/commit/b6784673dfdfd60bd1d7b6dc882ff45dac314a45

Thank you for contribute to Mozilla :)