959499 - B2G Mochitests on Device: Ability to register to a specific wifi network

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[[e-mail] [:onecyrenus]]

To run mochitests on device you have to have the host machine and the client on the same wifi network. 

Currently there is no mechanism to configure the device to connect to a specific wifi access point. 

The mechanism now is to setup the device manually prior to a test run.

Comment 1

[Andrew Halberstadt [:ahal]]

Good idea, we can use https://developer.mozilla.org/en-US/docs/Web/API/WifiManager.associate to try and connect to the network the host is hooked up to.

It would be cool if we could just access the functions in gaiatest's gaia_test.py (https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L333) without needing to import everything else.. but that's another bug for another time.

Comment 2

[[e-mail] [:onecyrenus]]

Attachment: Bug_95499.patch

Tested seems to work against Mozilla Guest

Comment 3

[[e-mail] [:onecyrenus]]

Attachment: Bug_95499.patch

Slightly better help documentation

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8360892 [details] [diff] [review]
Bug_95499.patch

Review of attachment 8360892 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a few nits and suggestions. I'd like to see an example of what to type at the command line.. I guess it isn't a huge deal, especially if most people are using mach these days anyway.

::: testing/mochitest/b2g_start_script.js
@@ +85,5 @@
> +  let manager = navigator.mozWifiManager;
> +  let con = manager.connection;
> +  if(wifiSettings) {
> +    if (manager.enabled) {
> +      manager.associate(wifiSettings);    

nit: trailing whitespace

@@ +87,5 @@
> +  if(wifiSettings) {
> +    if (manager.enabled) {
> +      manager.associate(wifiSettings);    
> +    } else {
> +      manager.onenabled = function () {  

nit: trailing whitespace

::: testing/mochitest/mochitest_options.py
@@ +574,5 @@
> +        [["--wifi"],
> +        { "action": "store",
> +          "type": "string",
> +          "dest": "wifi",
> +          "help": "Define mozWifiManager connection: network associate json string expected",

So we need to type json at the command line? That seems a little clunky :/. What's an example value you'd type? Should also mention it only works with a device build, maybe append (device only).

::: testing/mochitest/runtestsb2g.py
@@ +115,5 @@
>          self.buildURLOptions(options, {'MOZ_HIDE_RESULTS_TABLE': '1'})
> +        if not options.emulator:
> +          self.test_script_args.append(True)
> +        else:
> +          self.test_script_args.append(False)

This can be re-written as:
self.test_script_args.append(not options.emulator)

Comment 5

[[e-mail] [:onecyrenus]]

Attachment: Bug_95499.patch

+nit fix

Comment 6

[[e-mail] [:onecyrenus]]

Andrew, 
  Possibly the mach command would read in a specific wifi file and pass it to the command line ? I just wasn't sure we needed an entire file for what will probably be a small  json object.. 

https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/gaia-ui-tests/Gaia_UI_Tests_Run_Tests#How_to_configure_WiFi_using_testvars.json_%28for_devices%29

The gaia ui tests use a configuration file which passes the same type of object into the test harness. 

The documentation is usually on mdn for this type of feature ? Maybe a follow up bug for documentation?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31993b8e06cc

Comment 8

[Andrew Halberstadt [:ahal]]

This was backed out in:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5041c3109c5a

Comment 9

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=22d013be7e55

Comment 10

[[e-mail] [:onecyrenus]]

Attachment: Bug_959499.patch

Ran this through emulator, and seems fine now. 
Removed some defunk permissions from the manifest.webapp
Added the proxy configuration piece in there as well to make the patch complete.

Comment 11

[Andrew Halberstadt [:ahal]]

Comment on attachment 8367194 [details] [diff] [review]
Bug_959499.patch

Review of attachment 8367194 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lgtm.. as long as you are sure those permissions are deprecated :)

Comment 12

[Andrew Halberstadt [:ahal]]

Comment on attachment 8367194 [details] [diff] [review]
Bug_959499.patch

Review of attachment 8367194 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, just noticed that try run is busted, something is up.

Comment 13

[Andrew Halberstadt [:ahal]]

JSON.parse probably doesn't like when we pass None into it.

Comment 14

[Andrew Halberstadt [:ahal]]

Also for future, you can use the try syntax 'try: -b o -p emulator -u mochitest-1 -t none' to only run emulator mochitests.

In this case, it's the b2g desktop mochitests that have broken so you'd use 'try: -b o -p linux64_gecko -u mochitest -t none'

See http://trychooser.pub.build.mozilla.org/ for help building syntax.

Comment 15

[[e-mail] [:onecyrenus]]

Attachment: Bug_95499.patch

https://tbpl.mozilla.org/?tree=Try&rev=df0c473829d7

Re-ran the broken tests with the updated patch. 
Added a check for wifiSettings prior to attempting to Parse. 
The default value for wifiSettings is False not None as well.

Comment 16

[Andrew Halberstadt [:ahal]]

Comment on attachment 8368083 [details] [diff] [review]
Bug_95499.patch

Review of attachment 8368083 [details] [diff] [review]:
-----------------------------------------------------------------

I think you attached the wrong patch. The one in try looks good, but this one still doesn't check for wifiSettings first.

::: testing/mochitest/b2g_start_script.js
@@ +85,5 @@
> +  let manager = navigator.mozWifiManager;
> +  let con = manager.connection;
> +  if(wifiSettings) {
> +    if (manager.enabled) {
> +      manager.associate(wifiSettings);    

nit: trailing whitespace

@@ +87,5 @@
> +  if(wifiSettings) {
> +    if (manager.enabled) {
> +      manager.associate(wifiSettings);    
> +    } else {
> +      manager.onenabled = function () {  

nit: trailing whitespace

Comment 17

[[e-mail] [:onecyrenus]]

Attachment: Bug_95499.patch

unsure how that happened ? let me try again

Comment 18

[[e-mail] [:onecyrenus]]

Attachment: Bug_959499.patch

problem found, incorrect patch

Comment 19

[Andrew Halberstadt [:ahal]]

Comment on attachment 8368192 [details] [diff] [review]
Bug_959499.patch

Review of attachment 8368192 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! And try run looks good too.

Comment 20

[[e-mail] [:onecyrenus]]

crosses fingers :)

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b8784894c96

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b8784894c96