Closed Bug 959523 Opened 10 years ago Closed 10 years ago

Findbar broken in trunk (c-c) builds

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: aleth)

References

Details

Attachments

(1 file, 1 obsolete file)

Pressing Command+F in a conversation window gives:
Timestamp: 14/01/14 10:42:21
Error: TypeError: this.browser.finder is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 481

In the log viewer, I get:
Timestamp: 14/01/14 10:24:51
Error: TypeError: this._browser.finder is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 262
Attached patch 959523.patch (obsolete) — Splinter Review
Ports toolkit browser changes from Bug 666816.

I wonder if there are other changes in browser.xml which we should merge? E.g. the scrolling code looks like it has become more complex.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8362916 - Flags: review?(florian)
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 955722
Comment on attachment 8362916 [details] [diff] [review]
959523.patch

Review of attachment 8362916 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

You may want to change the commit message to something a bit more descriptive of the change before it's checked in.
Attachment #8362916 - Flags: review?(florian) → review+
Attached patch 959523.patchSplinter Review
Good idea.
Attachment #8362916 - Attachment is obsolete: true
Attachment #8362949 - Flags: review?(florian)
Attachment #8362949 - Flags: review?(florian) → review+
Whiteboard: checkin-needed
https://hg.mozilla.org/comm-central/rev/95758315e5a1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
You need to log in before you can comment on or make changes to this bug.