959585 - contentEditable span or div onblur alert can't be clicked

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Cees T.]

Attachment: onblur_alert_test.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140113004002

Steps to reproduce:

Run attached testcase in Aurora and Chrome.


Actual results:

Aurora fails. Chrome wins.


Expected results:

Both win.

Comment 1

[Cees T.]

The testcase works here; I think NoScript is causing problems again.

Comment 2

[Cees T.]

Restarting with all addons disabled, the testcase shows an alert, but i can't click the OK button on it. Pressing Esc does dismiss it.

Comment 3

[Alice0775 White]

STR
1. Open attached testcase
2. Click two
3. Click one
4. Attempt to click OK button in alert box

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cbe04dbc2bd6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131217160921
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/08dc60299942
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131217161358
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cbe04dbc2bd6&tochange=08dc60299942

Regresseed by:
08dc60299942	Blake Kaplan — Bug 933483 - Don't fire events (and especially request animation frame events) when we're in a modal dialog. r=smaug

Comment 4

[Alice0775 White]

I can also reproduce the problem on Linux.

Comment 5

[(no longer active)]

Blake, can you please take a look?  Thanks!

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking for website breakage risk.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: clear capturing content

Comment 8

[Neil Deakin]

Comment on attachment 8366306 [details] [diff] [review]
clear capturing content

SetCapturingContent is static, so you don't need to get the presshell.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Ah, yes. Shouldn't have copied that part from above.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: clear_capturing_content_when_entering_modal_state_2.diff

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/042a31391d55


mrbkap, on which branches do we need this?

Comment 12

[Gregor Wagner [:gwagner]]

The bug that caused this is koi+. Could we get this to all relevant trees?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

That's not at all a decision for sheriffs to make.

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8366306 [details] [diff] [review]
clear capturing content

Obsoleting in favor of the patch that was checked in.

Olli, I believe that this will need to apply on Aurora and b2g26_v1_2.

Comment 15

[Jason Smith [:jsmith]]

We're no longer maintaining 1.2, so moving to 1.3 for triage.

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/042a31391d55

Comment 17

[Preeti Raghunath(:Preeti)]

1.3+ for compatibility of website issue

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/95af3eb13175

My understanding was that we're still taking some patches for v1.2 if they affect partner qualification? I guess we don't expect this bug to significantly affect that?

Comment 19

[Jason Smith [:jsmith]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #18)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/95af3eb13175
> 
> My understanding was that we're still taking some patches for v1.2 if they
> affect partner qualification? I guess we don't expect this bug to
> significantly affect that?

To my understanding, we don't have any partners lined up using our 1.2 branch right now.

Comment 20

[Preeti Raghunath(:Preeti)]

From a relman perspective we will not be picking up the issue in 1.2.