959596 - PDF with annotations is incorrectly printed from Windows

Status: RESOLVED WORKSFORME

(Firefox :: PDF Viewer, defect, P3)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: annotations print

Reproducible on:
latest Nightly (20140113030203)
Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 
latest Aurora (20140114004002)
Mozilla/5.0 (Windows NT 5.1; rv:28.0) Gecko/20100101 Firefox/28.0 
Firefox 27 beta 6 (20140113161826)
Mozilla/5.0 (Windows NT 5.1; rv:27.0) Gecko/20100101 Firefox/27.0 

Steps to reproduce:
1. Launch Firefox
2. Open http://mozqa.com/data/firefox/pdf/annotationsAndOutline.pdf
3. Select to print the file and verify the output

Expected results: 
The pdf is correctly printed.

Actual results: 
The text is jerky, please see the attachment.

Notes:
1. The issue is not reproducible with Firefox 19 and Firefox 26
2. The issue is reproducible with Firefox 27 beta 1 (recent regression)
3. No printing issues with another pdfs with annotations such as https://bug741239.bugzilla.mozilla.org/attachment.cgi?id=611315 or https://bug741239.bugzilla.mozilla.org/attachment.cgi?id=778613

Comment 1

[bhavana bajaj [:bajaj]]

NI on :bdahl to help with investigation.

Comment 2

[Petruta Horea [:phorea], Desktop QA]

Please find the regression range:
Last good revision: 9f8233fcce1d <2013-10-25>
First bad revision: ef3f5669b53e <2013-10-26>
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9f8233fcce1d&tochange=ef3f5669b53e

I had issues when I tried to bisect further: "Exception WindowsError: (2, 'The system cannot find the file specified', u'firefox-27.0a1.en-US.win32.zip') in <bound method FirefoxNightly.cleanup of <mozregression.runnightly.FirefoxNightly object at 0x0132C070>> ignored".

Please let me know if there is anything else I can help with.

Comment 3

[bhavana bajaj [:bajaj]]

bdahl, any luck to reproducing this?

Comment 4

[Brendan Dahl [:bdahl]]

Yes. I haven't tried removing the changes but it's highly likely this regression came from Bug 811002 which is in the above change log. I'll try to revert these changes and try things out tomorrow.

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to Brendan Dahl [:bdahl] from comment #4)
> Yes. I haven't tried removing the changes but it's highly likely this
> regression came from Bug 811002 which is in the above change log. I'll try
> to revert these changes and try things out tomorrow.

we are going to go-to-build with one of our final beta for Desktop today, should i consider this as a wontfix in that case for this cycle ?

Do we understand what kind of pdf's are impacted, would this be a common use case?

Comment 6

[Brendan Dahl [:bdahl]]

I would consider this a won't fix for this cycle. As for which pdfs are affected, this is currently the only pdf I know that exhibits this issue.

My windows build is finally working again, so I should be able to verify the regression commit in a few hours.

Comment 7

[Brendan Dahl [:bdahl]]

I can confirm part 1 of bug 811002 causes the regression.

Bas, any ideas here? Does this cause a different font engine to be used?

Comment 8

[Bas Schouten (:bas.schouten)]

(In reply to Brendan Dahl [:bdahl] from comment #7)
> I can confirm part 1 of bug 811002 causes the regression.
> 
> Bas, any ideas here? Does this cause a different font engine to be used?

To some extent, yes, fixing this bug caused us to actually print text as text, rather than bitmaps (i.e. it draws them with the GDI font engine (when printing), rather than as bitmaps retrieved from our font engine).

Comment 9

[Brendan Dahl [:bdahl]]

BTW windows computers with hardware acceleration are unaffected.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Brendan, we still have a couple of weeks of FF28 on Beta where we can take slightly more speculative fixes and/or a backout - can you update on your progress here?

Comment 11

[Brendan Dahl [:bdahl]]

I've made no progress. Gfx on windows is outside my expertise and I don't think I'll be able to find a solution without spending a significant amount of time.

If someone from gfx can look into this, that would be ideal. Otherwise, I suggest we back out the patch and regress the quality of print output.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Milan can you help get some gfx expertise on this?

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, but it will take a while, as mentioned in the platform meeting.  I will leave needinfo on me.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

This will have to remain unfixed in FF28 as we are now wrapping up the beta cycle.

Comment 15

[Milan Sreckovic [:milan] (needinfo for best results)]

Bas, can you take a look at this?  Let's see if we can get a trunk fix and then how well it uplifts to 29.  It'd probably be good to do it before the work week if possible.

Comment 16

[Bas Schouten (:bas.schouten)]

(In reply to Petruta Rasa [QA] [:petruta] from comment #0)
> Created attachment 8359791 [details]
> annotations print
> 
> Reproducible on:
> latest Nightly (20140113030203)
> Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 
> latest Aurora (20140114004002)
> Mozilla/5.0 (Windows NT 5.1; rv:28.0) Gecko/20100101 Firefox/28.0 
> Firefox 27 beta 6 (20140113161826)
> Mozilla/5.0 (Windows NT 5.1; rv:27.0) Gecko/20100101 Firefox/27.0 
> 
> Steps to reproduce:
> 1. Launch Firefox
> 2. Open http://mozqa.com/data/firefox/pdf/annotationsAndOutline.pdf
> 3. Select to print the file and verify the output
> 
> Expected results: 
> The pdf is correctly printed.
> 
> Actual results: 
> The text is jerky, please see the attachment.
> 
> Notes:
> 1. The issue is not reproducible with Firefox 19 and Firefox 26
> 2. The issue is reproducible with Firefox 27 beta 1 (recent regression)
> 3. No printing issues with another pdfs with annotations such as
> https://bug741239.bugzilla.mozilla.org/attachment.cgi?id=611315 or
> https://bug741239.bugzilla.mozilla.org/attachment.cgi?id=778613

I can't reproduce a problem with this file on windows 7 with Direct2D turned off, every way I print this it looks fine to me.. could we get a scan pointing out what exactly I'm looking for?

Comment 17

[Petruta Horea [:phorea], Desktop QA]

Attachment: d2dOnAndOff.pdf

(In reply to Bas Schouten (:bas.schouten) from comment #16)
> I can't reproduce a problem with this file on windows 7 with Direct2D turned
> off, every way I print this it looks fine to me.. could we get a scan
> pointing out what exactly I'm looking for?

The attachment added in 14th Jan is a scan copy of the file printed from Win XP.

I retested using latest Nightly (20140326030203) under Win 7 64-bit. Please see the new attachment with two pages representing the scan with the pref gfx.direct2d.disabled set to true and false. (I'm hoping this is the correct pref)

Comment 18

[Bas Schouten (:bas.schouten)]

(In reply to Petruta Rasa [QA] [:petruta] from comment #17)
> Created attachment 8397701 [details]
> d2dOnAndOff.pdf
> 
> (In reply to Bas Schouten (:bas.schouten) from comment #16)
> > I can't reproduce a problem with this file on windows 7 with Direct2D turned
> > off, every way I print this it looks fine to me.. could we get a scan
> > pointing out what exactly I'm looking for?
> 
> The attachment added in 14th Jan is a scan copy of the file printed from Win
> XP.
> 
> I retested using latest Nightly (20140326030203) under Win 7 64-bit. Please
> see the new attachment with two pages representing the scan with the pref
> gfx.direct2d.disabled set to true and false. (I'm hoping this is the correct
> pref)

Interesting, I was confused by all the invalid fonts in the rest of the page. So it seems you're seeing the bug with direct2d enabled (i.e. direc2d.disabled set to false), are you certain this is correct? Since the bug is reported for WinXP, where direct2d doesn't exist.

Comment 19

[Bas Schouten (:bas.schouten)]

FWIW, I finally managed to print something with direct2d on, and it prints just fine, so I'm completely at a loss as to how I will be able to reproduce this bug.

Comment 20

[Petruta Horea [:phorea], Desktop QA]

I also printed from that system another random pdf, and I didn't encounter any problems.
Is there any other tests I could try in order to see if this is a d2d problem or not?

Comment 21

[Brendan Dahl [:bdahl]]

I was able to reproduce on a win xp virtual machine with FF2014-03-27.

I assume you guys are printing the url in the bug description, NOT the attached PDF?

http://mozqa.com/data/firefox/pdf/annotationsAndOutline.pdf ?

Comment 22

[Bas Schouten (:bas.schouten)]

(In reply to Brendan Dahl [:bdahl] from comment #21)
> I was able to reproduce on a win xp virtual machine with FF2014-03-27.
> 
> I assume you guys are printing the url in the bug description, NOT the
> attached PDF?
> 
> http://mozqa.com/data/firefox/pdf/annotationsAndOutline.pdf ?

Yes, I am. Perhaps this is a problem strictly related to something inside WinXP? Like a font there or something. I don't have an up to date WinXP machine sadly.

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Is it possible to get a reduced test case of this problem? It would make analyzing what's happening easier

Comment 24

[Jeff Muizelaar [:jrmuizel]]

It's also worth noting that pdf.js would produce nicer pdfs and have better performance if it didn't draw each character individually. It seems reasonably to have pdf.js preserve strings at the same granularity that they are in the original document.

Comment 25

[Sylvestre Ledru [:Sylvestre]]

Any chance this bug can be fixed for 29? beta6 and 7 are planned for this week.
Thanks

Comment 26

[Sylvestre Ledru [:Sylvestre]]

29 is going live soon. So, too late for 29.
Not tracking for the next releases.

Comment 27

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 28

[Marco Castelluccio [:marco]]

Is this only reproducible on Windows XP? If so, we can close this as WONTFIX.

Comment 29

[Petruta Horea [:phorea], Desktop QA]

(In reply to Marco Castelluccio [:marco] from comment #28)

Is this only reproducible on Windows XP? If so, we can close this as WONTFIX.

I noted in comment 18 that Win 7 was also affected.
However, the pdf is no longer available (404 - Not Found) and I couldn't find another copy of it, so I guess this issue + bug 959553 can be closed now.

Comment 30

[Marco Castelluccio [:marco]]

I found it on another website: http://dgt.gob.gt/PdfView/test/mozcentral/file_pdfjs_test.pdf.

Comment 31

[Marco Castelluccio [:marco]]

Attachment: annotationsAndOutline.pdf

Comment 32

[Marco Castelluccio [:marco]]

Are you still able to reproduce the bug?

Comment 33

[Petruta Horea [:phorea], Desktop QA]

Looks good to me on Print Preview using latest Firefox versions under Win 7 32-bit and Win 10 64-bit.

I don't own a physical printer to actually test this, so passing the ni? to Bogdan (currently OOO).

Comment 34

[Bogdan Maris, Desktop QA]

I used a physical printer (HP Deskjet 3720) on both Windows 7 32bit and Windows 11 and the PDF from comment 30 is printed without issues on paper as well. Based on Comment 33 and this one I will go ahead and close this bug as WORKSFORME.