959629 - Gaia integration need new NodeJS module

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Hubert Figuiere [:hub]]

Gaia integration need new NodeJS module: we need exec-sync that require a native compilation to install.

See 917717 comment 47

Thanks.

Comment 1

[Hubert Figuiere [:hub]]

I mean see bug 917717 comment 47

Comment 2

[Julien Wajsberg [:julienw]]

Why can't we add it to package.json ?

Comment 3

[Hubert Figuiere [:hub]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Why can't we add it to package.json ?

Here it the full log of the failure:
https://tbpl.mozilla.org/php/getParsedLog.php?id=32930299&full=1&branch=b2g-inbound

tl;dr if you need a native module compilation it won't install by itself on TBPL

Comment 4

[Julien Wajsberg [:julienw]]

Yeah, and locally I needed "npm install -d" with my npm 0.8.

Comment 5

[Hubert Figuiere [:hub]]

The important module that need compilation is actually "ffi". "exec-sync" does not require native code.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Hi Hub,

A few points for cla


1. I think releng can give you access to ubuntu 32 and 64 bit machines that you may use to precompile the modules yourself (by doing something similar to https://github.com/mozilla-b2g/sockit-to-me/blob/master/tools/prebuild.sh), but my guess is that they won't build them for you?

2. Since npm tries to compile modules during |npm install| that have .gyp files, you'll need to do something like https://github.com/mozilla-b2g/sockit-to-me/blob/master/package.json#L11 in the repo for the native module (which also probably involves forking and publishing a non-native version of the module in question). The purpose of this is to check for a compiler (ie g++) and then failover to copying existing binaries into the build output directory if a compiler isn't detected.

Does this make a bit more sense?

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

:%s/cla/clarity/

Comment 8

[Hubert Figuiere [:hub]]

and how do I publish it so npm finds it?

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

If you have exec-sync which depends on ffi, you could:

1. Fork ffi, change the name to something like ffi-non-native, modify it to use precompiled binaries if no g++, and publish it

2. Fork exec-sync and change the name to something like exec-sync-non-native, depend on ffi-non-native instead of ffi, and publish it

3. In the marionette perf package, depend on exec-sync-non-native instead of exec-sync

Does that make sense?

Comment 10

[Hubert Figuiere [:hub]]

Solution is as follow:

I will fork ffi, rename it ffi-prebuilt
https://github.com/hfiguiere/node-ffi

Then I will add the *generated* .js from exec-sync to our source tree (original is written in CoffeeScript anyway). MIT licensed and depend on that ffi-prebuilt.

Longer term, bug 959241 should make all that pain obsolete.

Comment 11

[Hubert Figuiere [:hub]]

Use ffi-prebuilt. It is available on npm and will pull proper dependencies, prebuilt.