Closed Bug 959667 Opened 9 years ago Closed 4 years ago

Don't store duplicate js files in packages

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: fabrice, Unassigned)

References

Details

Attachments

(2 files)

exclude-dupes.patch
6.32 KB, patch
Details | Diff | Splinter Review
github PR: https://github.com/mozilla-b2g/gaia/pull/15524
46 bytes, text/x-github-pull-request
Details | Review 
Currently we concatenate js files in gaia_build_defer_XXX.js but we also store the origin js files in the zip.

This patch filters out these duplicates. The gains are not great (a bit less than 1MB), but I see no reason to keep duplicates.

Yuren, what do you think?
That's great, we should fix it!
Assignee: nobody → yurenju.mozilla
This pull request is based on Fabrice's patch and it looks good on my side.

I will set the review flag if travis-ci turns green.

https://travis-ci.org/mozilla-b2g/gaia/builds/17266217
before is 25,268 KB
now is 24,505 KB
Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524

Tim, Could you help to review it? thanks!
Attachment #8362436 - Flags: review?(timdream)
Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524

I disagree with the fix. Do we really need a untracked file to tell which file to exclude? Is there a better API? Or there is but you just want to save some time now and deliver proper fix later?
Attachment #8362436 - Flags: review?(timdream)
okay, let's find some better way.
Progress??
Flags: needinfo?(yurenju.mozilla)
not much since last week got a lot of review.
Flags: needinfo?(yurenju.mozilla)
Tim, I would like to know the priority of this bug since it only took 700KB from storage which mentioned on comment 3
Flags: needinfo?(timdream)
We could put this on the pending queue for tarako priority, but this remain a valid bug.
Flags: needinfo?(timdream)
Component: Gaia → Gaia::Build
we can just remove these files when optimization done since we have build_stage for all apps now, but it should dependy on bug 987487
Depends on: 987487
un-assign myself since I don't have enough bandwidth to fix it.
Assignee: yurenju → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.