Closed
Bug 959667
Opened 11 years ago
Closed 7 years ago
Don't store duplicate js files in packages
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: fabrice, Unassigned)
References
Details
Attachments
(2 files)
6.32 KB,
patch
|
Details | Diff | Splinter Review | |
46 bytes,
text/x-github-pull-request
|
Details | Review |
Currently we concatenate js files in gaia_build_defer_XXX.js but we also store the origin js files in the zip.
This patch filters out these duplicates. The gains are not great (a bit less than 1MB), but I see no reason to keep duplicates.
Yuren, what do you think?
Comment 1•11 years ago
|
||
That's great, we should fix it!
Updated•11 years ago
|
Assignee: nobody → yurenju.mozilla
Comment 2•11 years ago
|
||
This pull request is based on Fabrice's patch and it looks good on my side.
I will set the review flag if travis-ci turns green.
https://travis-ci.org/mozilla-b2g/gaia/builds/17266217
Comment 3•11 years ago
|
||
before is 25,268 KB
now is 24,505 KB
Comment 4•11 years ago
|
||
travis passed
https://travis-ci.org/mozilla-b2g/gaia/builds/17266217
Comment 5•11 years ago
|
||
Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524
Tim, Could you help to review it? thanks!
Attachment #8362436 -
Flags: review?(timdream)
Comment 6•11 years ago
|
||
Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524
I disagree with the fix. Do we really need a untracked file to tell which file to exclude? Is there a better API? Or there is but you just want to save some time now and deliver proper fix later?
Attachment #8362436 -
Flags: review?(timdream)
Comment 7•11 years ago
|
||
okay, let's find some better way.
Comment 9•11 years ago
|
||
not much since last week got a lot of review.
Flags: needinfo?(yurenju.mozilla)
Comment 10•11 years ago
|
||
Tim, I would like to know the priority of this bug since it only took 700KB from storage which mentioned on comment 3
Flags: needinfo?(timdream)
Comment 11•11 years ago
|
||
We could put this on the pending queue for tarako priority, but this remain a valid bug.
Flags: needinfo?(timdream)
Updated•11 years ago
|
Component: Gaia → Gaia::Build
Comment 12•11 years ago
|
||
we can just remove these files when optimization done since we have build_stage for all apps now, but it should dependy on bug 987487
Depends on: 987487
Comment 13•11 years ago
|
||
un-assign myself since I don't have enough bandwidth to fix it.
Assignee: yurenju → nobody
Comment 14•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•