959667 - Don't store duplicate js files in packages

Status: RESOLVED WONTFIX

Description

[[:fabrice] Fabrice Desré]

Attachment: exclude-dupes.patch

Currently we concatenate js files in gaia_build_defer_XXX.js but we also store the origin js files in the zip.

This patch filters out these duplicates. The gains are not great (a bit less than 1MB), but I see no reason to keep duplicates.

Yuren, what do you think?

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

That's great, we should fix it!

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/15524

This pull request is based on Fabrice's patch and it looks good on my side.

I will set the review flag if travis-ci turns green.

https://travis-ci.org/mozilla-b2g/gaia/builds/17266217

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

before is 25,268 KB
now is 24,505 KB

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

travis passed
https://travis-ci.org/mozilla-b2g/gaia/builds/17266217

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524

Tim, Could you help to review it? thanks!

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8362436 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/15524

I disagree with the fix. Do we really need a untracked file to tell which file to exclude? Is there a better API? Or there is but you just want to save some time now and deliver proper fix later?

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

okay, let's find some better way.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Progress??

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

not much since last week got a lot of review.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Tim, I would like to know the priority of this bug since it only took 700KB from storage which mentioned on comment 3

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We could put this on the pending queue for tarako priority, but this remain a valid bug.

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we can just remove these files when optimization done since we have build_stage for all apps now, but it should dependy on bug 987487

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

un-assign myself since I don't have enough bandwidth to fix it.

Comment 14

[BMO Automation]

Firefox OS is not being worked on