959674 - background-blend-mode does not blend background images with the background color when the bottom most background image is opaque and has background-repeat:repeat

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Horia Iosif Olaru]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

Have a div with a background-color set and an opaque background-image (such as jpg). Set background-blend-mode to something other than normal (multiply for example). Set background-repeat:repeat, or do not set it at all to leave it default.


Actual results:

The image does not blend with the color.


Expected results:

The background image should blend with the background color.

Comment 1

[Horia Iosif Olaru]

Could someone please assign me to this bug?
I have a fix and will upload patches soon.

Comment 2

[Horia Iosif Olaru]

Attachment: One liner that fixes the bug

Comment 3

[Horia Iosif Olaru]

Attachment: Add a new reftest for regressing the issue

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Horia Iosif Olaru from comment #1)
> Could someone please assign me to this bug?

I've given you editbugs.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8359994 [details] [diff] [review]
One liner that fixes the bug

Review of attachment 8359994 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent catch, thanks!

Comment 6

[Josh Matthews [:jdm]]

https://tbpl.mozilla.org/?tree=Try&rev=364dc62fe83e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e7f8be8993b
https://hg.mozilla.org/integration/mozilla-inbound/rev/46ad3c81fd55

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e7f8be8993b
https://hg.mozilla.org/mozilla-central/rev/46ad3c81fd55

Comment 9

[Matej Kriz]

Hi, I'm expiriencing same issue on Firefox 33.0 on Ubuntu 14.04 LTS. But I will named it like: "background-blend-mode does not blend background images with the background color." (no other conditions). Watch this in FF: http://codepen.io/anon/pen/Jjxdh