Make ReportIsNotFunction take a Handle, not a reference, and fix callers that do unsafe ref stuff

RESOLVED FIXED in mozilla29

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla29
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
Created attachment 8359889 [details] [diff] [review]
part 1.  Make ValueToCallable take a Handle.
Attachment #8359889 - Flags: review?(terrence)
Created attachment 8359890 [details] [diff] [review]
part 2.  Make ReportIfNotFunction take a Handle.
Attachment #8359890 - Flags: review?(terrence)
Created attachment 8359891 [details] [diff] [review]
part 3.  Make ReportIsNotFunction take a Handle.
Attachment #8359891 - Flags: review?(terrence)
Comment on attachment 8359889 [details] [diff] [review]
part 1.  Make ValueToCallable take a Handle.

Review of attachment 8359889 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me
Attachment #8359889 - Flags: review?(terrence) → review+
Comment on attachment 8359890 [details] [diff] [review]
part 2.  Make ReportIfNotFunction take a Handle.

Review of attachment 8359890 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, fromMarkedLocation is the right approach there. r=me
Attachment #8359890 - Flags: review?(terrence) → review+
Comment on attachment 8359891 [details] [diff] [review]
part 3.  Make ReportIsNotFunction take a Handle.

Review of attachment 8359891 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ r=me
Attachment #8359891 - Flags: review?(terrence) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47da97e9521
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1b7f52cccdb
https://hg.mozilla.org/integration/mozilla-inbound/rev/675b925b575e
Flags: in-testsuite+
Target Milestone: --- → mozilla29

Comment 8

4 years ago
https://hg.mozilla.org/mozilla-central/rev/b47da97e9521
https://hg.mozilla.org/mozilla-central/rev/a1b7f52cccdb
https://hg.mozilla.org/mozilla-central/rev/675b925b575e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.