Closed
Bug 959695
Opened 12 years ago
Closed 12 years ago
Make ReportIsNotFunction take a Handle, not a reference, and fix callers that do unsafe ref stuff
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
3.50 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
2.74 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
11.08 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8359889 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8359890 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #8359891 -
Flags: review?(terrence)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8359889 [details] [diff] [review]
part 1. Make ValueToCallable take a Handle.
Review of attachment 8359889 [details] [diff] [review]:
-----------------------------------------------------------------
Great! r=me
Attachment #8359889 -
Flags: review?(terrence) → review+
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8359890 [details] [diff] [review]
part 2. Make ReportIfNotFunction take a Handle.
Review of attachment 8359890 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, fromMarkedLocation is the right approach there. r=me
Attachment #8359890 -
Flags: review?(terrence) → review+
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8359891 [details] [diff] [review]
part 3. Make ReportIsNotFunction take a Handle.
Review of attachment 8359891 [details] [diff] [review]:
-----------------------------------------------------------------
\o/ r=me
Attachment #8359891 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47da97e9521
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1b7f52cccdb
https://hg.mozilla.org/integration/mozilla-inbound/rev/675b925b575e
Flags: in-testsuite+
Target Milestone: --- → mozilla29
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b47da97e9521
https://hg.mozilla.org/mozilla-central/rev/a1b7f52cccdb
https://hg.mozilla.org/mozilla-central/rev/675b925b575e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•