Closed
Bug 959738
Opened 12 years ago
Closed 6 years ago
Propose adding (info) link next to Target Milestone field on show_bug.cgi to contain product specific information
Categories
(bugzilla.mozilla.org :: User Interface, enhancement)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file)
|
4.51 KB,
patch
|
glob
:
review-
|
Details | Diff | Splinter Review |
Similar to how we do with product and component currently, we can add an (info) link next to the Target Milestone drop down that will give documentation specific to the bug's product. This is instead of changing the Milestone label itself based on product which would need wide reaching changes to the BMO code base. Please let me know what the thoughts are on doing it in this manner. Patch coming.
dkl
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8359951 -
Flags: review?(glob)
Comment on attachment 8359951 [details] [diff] [review]
959738_1.patch
Review of attachment 8359951 [details] [diff] [review]:
-----------------------------------------------------------------
i'd like to get an outcome from the dev.planning discussion prior to implementing this.
::: extensions/BMO/template/en/default/hook/bug/edit-after_importance.html.tmpl
@@ +102,5 @@
> + Dom.get('toggle_milestone_desc_link').innerHTML = 'show info';
> + Dom.addClass('milestone_desc_container', 'bz_default_hidden');
> + }
> + });
> + }
this will be the third instance of a large amount of almost similar code, let's refactor that out into a function.
::: extensions/BMO/web/styles/edit_bug.css
@@ +45,5 @@
> }
>
> #toggle_prod_desc,
> +#toggle_comp_desc,
> +#toggle_milestone_desc {
probably makes sense to add a css class for these contains now, instead of having to specify each id.
Attachment #8359951 -
Flags: review?(glob) → review-
Updated•7 years ago
|
Type: defect → enhancement
Is this patch still valid?
Flags: needinfo?(dkl)
| Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Emma Humphries, Bugmaster ☕️🎸🧞♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #3)
Is this patch still valid?
Nope.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(dkl)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•