95977 - Startup with missing -url argument attempts to access site "1"

Status: RESOLVED WORKSFORME

(Core Graveyard :: Cmd-line Features, defect)

Description

[Peter Jones]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3) Gecko/20010801
BuildID:    2001080110

If I Run: 'F:\mozilla.org\Mozilla\mozilla.exe -url', the browser opens searching
for a nonexistent site "1". OTOH, if I Run 'F:\mozilla.org\Mozilla\mozilla.exe
-url ""', I get a blank page, as expected.

Reproducible: Always
Steps to Reproduce:
1. Run: 'F:\mozilla.org\Mozilla\mozilla.exe -url'


Actual Results:  Browser attempts to load a URL of "1"

Expected Results:  'Missing argument diagnostic, or blank page"

Comment 1

[David Illsley]

Also occurs Win2k 20010817

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

My vote is for about:blank.  A third option though would be to load the homepage.

Comment 3

[David Illsley]

Now WFM Win2k 20010905 (I get the same results as without any arguments)

Reporter: Please download a more recent version and see if the problem still
exists for you.

Comment 4

[Peter Jones]

I'm downloading the nightly build now. Is it sufficient to back up
C:\Windows\Application Data\Mozilla\Profiles\<myname>\ce8o6fvh.slt
in order to preserve my personal data?

Should the status be changed to ASSIGNED?

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

No it shouldn't be assigned, but it should be NEW since I confirmed it a while
ago as did david illsley.  (Assigned is when the engineer looks at it and agrees
that they are the right person to fix it).

I still see this on Linux (fresh CVS pull [0905] ) so moving to OS->All.

->XP Command Line

Comment 6

[sairuh (rarely reading bugmail)]

->trudelle for triage

Comment 7

[Peter Jones]

Build 2001090603 exhibits the problem, loud and clear.

Comment 8

[Peter Trudelle]

resolving as wontfix, anyone who feels strongly about it is welcome to fix it.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

This is definitely a bug and should not be marked wontfix.  If there is a patch
it will be accepted.

trudelle: if you don't intend to fix this yourself, then assign it to nobody and
set helpwanted.

Comment 10

[Peter Trudelle]

Sure it is a defect, what else could be marked wontfix? I just prefer to resolve
it as such to keep it distinct from other bugs that I am asking for help to fix.
Feel free reassign it if you disagree.

Comment 11

[Peter Trudelle]

resolving again, please do not reopen this unlees you reassign it.

Comment 12

[Matthew Tuck [:CodeMachine]]

WONTFIX is for "it's a feature, not a bug".

If you want to keep it separate, use [e-mail] and dont add the
helpwanted keyword.

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

> trudelle: if you don't intend to fix this yourself, then assign it to nobody and
> set helpwanted.

The reason you should not resolve this WONTFIX is the same reasons for which
LATER and REMIND are considered harmful.  See bug 35839 and bug 13534 for the
full list of reasons.


RE-OPENING!!!  Please do not resolve this until it is FIXED!!!

Comment 14

[Christopher Aillon (sabbatical, not receiving bugmail)]

Setting to nobody + helpwanted keyword.  Anyone is free to claim it.

Comment 15

[Peter Trudelle]

From A Bug's Life: 
"WONTFIX The problem described is a bug which will never be fixed."

This is a valid Bugzilla resolution, which is currently in use on over 2,500
bugs, including dozens assigned to mozilla.org folks like asa,dmose,leaf,gerv
and scc. 

Comment 16

[Andrew Schultz]

Attachment: patch

changes URL of "1" to "about:blank".

Comment 17

[Daniel Wang]

related? bug 166872
worksforme moz 2003032416/win98

Comment 18

[Christopher Aillon (sabbatical, not receiving bugmail)]

So is there a way to ask the cmdlineservice whether params were passed to the
cmdline arg?  I am assuming that the "1" is sort of a truth thing which says
that the requested value (in this case "-url") was explicitly set on the
cmdline.  Is there a better way to do this?  There may not be, but I am unsure.
 Boris?

Comment 19

[Boris Zbarsky [:bzbarsky]]

The "1" comes from
http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsCommandLineService.cpp#136

One way to improve on this setup would be to use an exception or boolean out
param (I prefer the latter) to indicate whether the option was set/used at all.
 Then the string return value only needs to be set if the option was used and it
can be set to whatever actually came after the option, if anything...

There are probably other ways to do this that involve larger changes to
nsICmdLineService (not necessarily a bad idea).

Comment 20

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 76935 [details] [diff] [review]
patch

I tend to agree with bz here.  Actually, to be honest, I"m not even sure I'm
really the best person to be reviewing this so I will recuse myself from the
duty.  I'm not sure who a good person to ask would be...