Rename drawSystemFocusRing to drawFocusIfNeeded

RESOLVED FIXED in mozilla29

Status

()

Core
Canvas: 2D
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Rik Cabanier, Assigned: Rik Cabanier)

Tracking

(Blocks: 1 bug, {access, dev-doc-complete, html5})

Trunk
mozilla29
access, dev-doc-complete, html5
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The HTML A11y group decided to rename drawSystemFocusRing to drawFocusIfNeeded since it is less confusing.
(Assignee)

Updated

3 years ago
Blocks: 935992
Keywords: access, html5
(Assignee)

Comment 1

3 years ago
Created attachment 8360152 [details] [diff] [review]
Renamed idl + impl + test files

Try run: https://tbpl.mozilla.org/?tree=Try&rev=0d606c9e0eeb
Attachment #8360152 - Flags: review?(roc)
(Assignee)

Updated

3 years ago
Assignee: nobody → cabanier
Comment on attachment 8360152 [details] [diff] [review]
Renamed idl + impl + test files

Review of attachment 8360152 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8360152 - Flags: review?(roc) → review+
By the way, should we remove drawCustomFocusRing? It seems the name and/or behavior are likely to change and it won't be standardized for some time.
(Assignee)

Comment 4

3 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> By the way, should we remove drawCustomFocusRing? It seems the name and/or
> behavior are likely to change and it won't be standardized for some time.

I was planning on leaving it behind the runtime flag for now. 
Maybe it's better to remove it since it is not going to be adopted? If you think so, I will create a bug to remove it.
(Assignee)

Updated

3 years ago
Attachment #8360152 - Flags: checkin?(ryanvm)
Maybe it should have its own runtime flag. We probably should enable drawFocusIfNeeded before drawCustomFocusRing.
(Assignee)

Comment 6

3 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> Maybe it should have its own runtime flag. We probably should enable
> drawFocusIfNeeded before drawCustomFocusRing.

OK. I will introduce a new flag for customfocusring.
Attachment #8360152 - Flags: checkin?(ryanvm)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/81e542a2ab70
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81e542a2ab70
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
https://developer.mozilla.org/en-US/Firefox/Releases/29#Interfaces.2FAPIs.2FDOM
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.drawFocusIfNeeded
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.