Closed Bug 959821 Opened 9 years ago Closed 9 years ago

Make it painfully obvious that r= from a DOM peer is required to change test_interfaces.html

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: jst, Assigned: jst)

References

Details

Attachments

(1 file)

In order to avoid people missing the warnings about changes to test_interfaces.html needing review from a DOM peer we should make it painfully obvious that DOM peer review is required. While the current test does warn both in the header of the test and in the test failure, those warnings can easily be missed if one is modeling new API additions on changes that added existing APIs.
Assignee: nobody → jst
Summary: Make it painfully obvious that r= from a dom peer is required to change test_interfaces.html → Make it painfully obvious that r= from a DOM peer is required to change test_interfaces.html
This has r=peterv in private email already.
Attachment #8360034 - Flags: review+
Haha, this is probably the best patch that I've ever seen! :-)
I'm pretty disappointed that we got to this point :(
https://hg.mozilla.org/mozilla-central/rev/a2e041c80510
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
See Also: → 1348918
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.