Closed Bug 959825 Opened 11 years ago Closed 11 years ago

setSignedInUser in FxAccounts.jsm does not fetch keys and notify login observers if user's email is already verified

Categories

(Firefox :: Firefox Accounts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ckarlof, Unassigned)

References

Details

(Whiteboard: [qa?])

Here is the bit of relevant code:

    return internal.signedInUserStorage.set(record)
      .then(() => {
        if (!internal.isUserEmailVerified(credentials)) {
          internal.startVerifiedCheck(credentials);
        }
      });

For now, the workaround is that the login page will always say the user is unverified at login, and FxAccounts.jsm will figure out she is and do the right thing.
Whiteboard: [qa?]
Target Milestone: mozilla29 → ---
Do I understand correctly that the issue here is that the user might quit the browser after verifying their email address but before fetching and storing keys? Can't we set the .verified flag later in the process?
The fix for this is to:

internal.notifyObservers(ONLOGIN_NOTIFICATION);

in setSignedInUser(). It's already landed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: Firefox Sync: Backend → FxA
Product: Mozilla Services → Core
Product: Core → Firefox
You need to log in before you can comment on or make changes to this bug.