959861 - Play fragmented MP4 will assert.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Alfredo Yang (:alfredo)]

Please test page http://people.mozilla.org/~ayang/mp4/mp4.html. It asserts at [1] when plays second video.
From https://bugzilla.mozilla.org/show_bug.cgi?id=956194#c5, MediaSeekable() needs to called in MediaOmxReader::ReadMetadata().


[1] http://dxr.mozilla.org/mozilla-central/source/content/media/MediaDecoderStateMachine.cpp#1953

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: set_omx_seekable_flag

I'll add testcase later in this bug.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8360897 [details] [diff] [review]
set_omx_seekable_flag

Review of attachment 8360897 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but Chris Double normally reviews OMX, so he should look over this.

Comment 3

[Alfredo Yang (:alfredo)]

Testcase probably enables only on b2g-emulator (it uses software h264/aac decoder in this case). Linux should be ok if tryserver has gstreamer libraries.

Comment 4

[Alfredo Yang (:alfredo)]

Just found that tryserver's Android version is GB which doesn't support fragmented mp4. We need to find other way for this test case.

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: fragment_mp4_unseekable

Test case for this bug. It's enable only on B2G emulator with version >= 18 (JB).

It could be workable on Linux Firefox if gstreamer is enable on tryserver.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8362761 [details] [diff] [review]
fragment_mp4_unseekable

Review of attachment 8362761 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason your street.mp4 file isn't being added to my repo when I apply the patch, and it's not showing up in splinter review. The file is definitely in your patch. Very weird.

Comment 7

[Alfredo Yang (:alfredo)]

(In reply to Chris Pearce (:cpearce) from comment #6)
> Comment on attachment 8362761 [details] [diff] [review]
> fragment_mp4_unseekable
> 
> Review of attachment 8362761 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> For some reason your street.mp4 file isn't being added to my repo when I
> apply the patch, and it's not showing up in splinter review. The file is
> definitely in your patch. Very weird.

I guess splinter is smart enough to skip binary patch.
I've tried it on Linux and Mac, both are ok.

Comment 8

[Alfredo Yang (:alfredo)]

Attachment: set_omx_seekable_flag

Updated reviewer in patch, carry r+.

Comment 9

[Alfredo Yang (:alfredo)]

https://tbpl.mozilla.org/?tree=Try&rev=7166440343a1

Comment 10

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/integration/b2g-inbound/rev/b68184d3213d
https://hg.mozilla.org/integration/b2g-inbound/rev/f6c92db23b8f

Comment 11

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/b68184d3213d
https://hg.mozilla.org/mozilla-central/rev/f6c92db23b8f