Closed
Bug 959864
Opened 11 years ago
Closed 11 years ago
Support DTLS 1.2
Categories
(NSS :: Libraries, enhancement, P2)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.16.2
People
(Reporter: wtc, Assigned: mt)
References
Details
Attachments
(1 file, 2 obsolete files)
|
3.89 KB,
patch
|
mt
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
Now that NSS supports TLS 1.2, it should not be hard to support DTLS 1.2.
The patch is probably incomplete. I wrote it by searching for "DTLS_1_0"
in the nss/lib/ssl directory.
The max allowed DTLS version is already DTLS 1.2. By default only DTLS 1.0
is enabled.
|
Reporter | |
Comment 1•11 years ago
|
||
Martin also wrote a patch in bug 996237.
|
Assignee | |
Comment 2•11 years ago
|
||
Yeah, yours works better. I missed the HelloVerify bit. They are otherwise identical.
|
|
Reporter | |
Comment 3•11 years ago
|
||
This is Martin's patch from bug 996237.
Attachment #8360100 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 4•11 years ago
|
||
Martin, I added a few changes from my preliminary patch to your patch.
You can review the diffs against the v1 patch to see my changes. Thanks.
Attachment #8430996 -
Attachment is obsolete: true
Attachment #8430999 -
Flags: review?(martin.thomson)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8430999 [details] [diff] [review]
Patch v2 by Martin Thomson
Review of attachment 8430999 [details] [diff] [review]:
-----------------------------------------------------------------
That looks correct. And I can confirm that it works with itself and Chrome. I'm in the process of trying to find more peers to test with; none of the ones I've tested with use HelloVerify, for instance. Unit tests would really help with my confidence level here.
Attachment #8430999 -
Flags: review?(martin.thomson) → review+
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 8430999 [details] [diff] [review]
Patch v2 by Martin Thomson
Patch checked in: https://hg.mozilla.org/projects/nss/rev/c6c37cdbad0d
Attachment #8430999 -
Flags: checked-in+
|
|
Reporter | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•