Status

enhancement
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: wtc, Assigned: mt)

Tracking

trunk
3.16.2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Posted patch Preliminary patch (obsolete) — Splinter Review
Now that NSS supports TLS 1.2, it should not be hard to support DTLS 1.2.

The patch is probably incomplete. I wrote it by searching for "DTLS_1_0"
in the nss/lib/ssl directory.

The max allowed DTLS version is already DTLS 1.2. By default only DTLS 1.0
is enabled.
Martin also wrote a patch in bug 996237.
Assignee: nobody → martin.thomson
Blocks: 996237
Status: NEW → ASSIGNED
Target Milestone: --- → 3.16.2
Yeah, yours works better. I missed the HelloVerify bit. They are otherwise identical.
Posted patch Patch v1 by Martin Thomson (obsolete) — Splinter Review
This is Martin's patch from bug 996237.
Attachment #8360100 - Attachment is obsolete: true
Martin, I added a few changes from my preliminary patch to your patch.
You can review the diffs against the v1 patch to see my changes. Thanks.
Attachment #8430996 - Attachment is obsolete: true
Attachment #8430999 - Flags: review?(martin.thomson)
Comment on attachment 8430999 [details] [diff] [review]
Patch v2 by Martin Thomson

Review of attachment 8430999 [details] [diff] [review]:
-----------------------------------------------------------------

That looks correct.  And I can confirm that it works with itself and Chrome.  I'm in the process of trying to find more peers to test with; none of the ones I've tested with use HelloVerify, for instance.  Unit tests would really help with my confidence level here.
Attachment #8430999 - Flags: review?(martin.thomson) → review+
Comment on attachment 8430999 [details] [diff] [review]
Patch v2 by Martin Thomson

Patch checked in: https://hg.mozilla.org/projects/nss/rev/c6c37cdbad0d
Attachment #8430999 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.