959880 - Support basic HTML markup in home banner text

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

This idea was mentioned and dismissed in bug 905262, but the mockups in bug 958891 include text that looks like a link. In order to do that, we'll need to add support for it.

Comment 1

[:Margaret Leibovic]

I thought it would be easy to do this using Html.fromHtml, but it looks like TextView.setText doesn't accept HTML-style formatting:
http://developer.android.com/reference/android/widget/TextView.html#setText%28java.lang.CharSequence%29

In order to do what we want for bug 958891 (adding a link), we may need to do something like what we do for doorhangers:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/DoorHanger.java#170

However, this would involve changing the Home.banner API to specify some link text or something, since this would have to happen in Java.

Comment 2

[:Margaret Leibovic]

Attachment: patch

Doh, my testcase was just bad. This actually was easy to implement.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/44709d5c8a99

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/44709d5c8a99