Closed
Bug 959926
Opened 11 years ago
Closed 11 years ago
Some random unsafe pointer ggc fixes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
5.58 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8360191 -
Flags: review?(terrence)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8360191 [details] [diff] [review]
Fix some miscellaneous unsafe pointer hazards.
Review of attachment 8360191 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
::: js/src/jsobj.cpp
@@ +5255,5 @@
> + return IsDelegateOfObject(cx, obj, &v.toObject(), result);
> +}
> +
> +bool
> +js::IsDelegateOfObject(JSContext *cx, HandleObject protoObj, JSObject* obj, bool *result)
Nice!
::: js/src/jsobj.h
@@ +1535,5 @@
>
> extern bool
> IsDelegate(JSContext *cx, HandleObject obj, const Value &v, bool *result);
>
> +// obj is a JSObject*, but we root it immediately up front. We do it
One space between sentences.
Attachment #8360191 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla29
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•