959983 - NFC: There should be an icon for NFC on the status bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Like Bluetooth, when we enable NFC there should be an icon for telling user NFC has been enabled.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Ken
I think it's a very basic feature for NFC. It should be 1.4+

Comment 2

[Ken Chang[:kenkai]]

I wonder if UX team can design this for NFC. By the way, there isn't a NFC status bar in other devices, you could double check it again. Partner also request this, so please talk with them. But I wonder if it is a vendor specific feature.

Comment 3

[Juwei Huang[:juwei]]

We've already updated this icon months ago,
Please check https://github.com/mozilla-b2g/gaia/tree/master/apps/system/style/statusbar/images

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

request to 1.5+

Comment 5

[Ken Chang[:kenkai]]

Wesley, who can help this in Gaia.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Candice, is this in systemfe's plate?

Comment 7

[Candice Serran (:cserran)]

(In reply to Wesley Huang [:wesley_huang] from comment #6)
> Candice, is this in systemfe's plate?

Yes, confirmed this is systemsfe bug. Updating whiteboard tag and added to our backlog.

Comment 8

[Peter Dolanjski [:pdol]]

I'm moving this to backlog for now.  I fully acknowledge that it is quite important for NFC to inform the user of status, but it is not clear that we'll block 1.5 on NFC at this point.  If that changes, we can definitely bump it up.

Comment 9

[Ken Chang[:kenkai]]

Wesley, I think NFC is one of key features in 1.5, right?

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Yes. NFC (sharing) is key focus in 1.5, so there will be obvious user interactions.
Suggest to implement this icon per defined by UX.

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Just realized this status icon is needed for partner in 1.5 timeframe.(bug 972778)
Set to 1.5? again.

Comment 12

[Wayne Chang [:wchang]]

For triage information - this is requested by partners as mentioned in comment 11 and they are unable to take this one.

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

NFC p2p sharing is defined as key focus in 2.0, so I'm setting this + for this is obvious user experience flaw.

Comment 15

[[e-mail]]

Attachment: pull request redirect to github

@greg I mapped NFC stat 0(NFC_HW_STATE_OFF)-> hide icon , 1~3-> show icon on statusbar.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

Should ask Yoshi that if `NFC_HW_STATE_DISABLE_DISCOVERY` means it's active.

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #16)
> Should ask Yoshi that if `NFC_HW_STATE_DISABLE_DISCOVERY` means it's active.

It means in low power mode, it cannot detect nor get detected,
but the hardware is still enabled.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

So it should be treated as inactive?

Comment 19

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

When in low power mode, it still could be in card emulation mode, which is related to payment.
But we don't support it for now.

We could file a new bug to discuss this special case.

Comment 20

[[e-mail]]

So it sounds like `stat 0(NFC_HW_STATE_OFF)-> hide icon` is right in current stage.

Do you know how other platform the NFC status is displayed in low power mode?

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

Asked Juwei (UX): it's OK to show the icon at the `NFC_HW_STATE_DISABLE_DISCOVERY` state.

So Comment 15 is a correct way to implement this.

Comment 22

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

LG Nexus 5 doesn't have icon for NFC.
Sony still shows NFC icon in low power mode.

Sorry I don't know about Samsung.

Comment 23

[[e-mail]]

Comment on attachment 8411552 [details] [review]
pull request redirect to github

travis passed

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8411552 [details] [review]
pull request redirect to github

r+ if event name is changed and unit test for nfcmanager part

Comment 25

[[e-mail]]

add nfc_manager test case and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/ed00198def12a2df82fb8e4277fa5c3ed2471dd5

thanks!