Closed
Bug 959999
Opened 10 years ago
Closed 10 years ago
[TSF] Clean up nsTextStore::Initialize()
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: masayuki, Assigned: masayuki)
Details
(Keywords: inputmethod)
Attachments
(1 file)
|
10.75 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
nsTextStore::Initialize() is very ugly. I really want to clean up this!
|
Assignee | |
Comment 1•10 years ago
|
||
Using local variable of nsRefPtr and nsRefPtr::swap() allows to make the code style "early return style" easily.
Attachment #8360865 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 2•10 years ago
|
||
FYI: all objects are necessary. So, if getting one of them failed, we should fallback to IMM mode.
|
||
Updated•10 years ago
|
Attachment #8360865 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b07a04f280f
https://hg.mozilla.org/mozilla-central/rev/7b07a04f280f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•