Initialize the observer right away in start method in firefox/lib/modal-dialog.js

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cosmin-malutan, Assigned: cosmin-malutan)

Tracking

unspecified

Firefox Tracking Flags

(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 fixed)

Details

Attachments

(1 attachment)

We need to initialize the observer for watching new modalls openings right away in start method without delay as this blocks bug 795398.
(Assignee)

Comment 1

5 years ago
Created attachment 8360450 [details] [diff] [review]
patch v1.0

Here is the patch for default branch.

The reports from bug 795398, proves it doesn't broke anything.
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8360450 - Flags: review?(andrei.eftimie)
Attachment #8360450 - Flags: review?(andreea.matei)
(Assignee)

Updated

5 years ago
status-firefox26: --- → affected
status-firefox27: --- → affected
status-firefox28: --- → affected
status-firefox29: --- → affected
status-firefox-esr24: --- → affected
(Assignee)

Comment 2

5 years ago
Patch applies cleanly on all branches.
Comment on attachment 8360450 [details] [diff] [review]
patch v1.0

Review of attachment 8360450 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Make sure it also passes on all branches locally. I can land on default now with an updated commit message.
Attachment #8360450 - Flags: review?(andrei.eftimie)
Attachment #8360450 - Flags: review?(andreea.matei)
Attachment #8360450 - Flags: review+
status-firefox29: affected → fixed

Comment 6

5 years ago
Landed backports:
http://hg.mozilla.org/qa/mozmill-tests/rev/7cd3d76daf72 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/66dc6e0c3f79 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/44c4994c633d (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/e848717e9bef (mozilla-esr24)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox26: affected → fixed
status-firefox27: affected → fixed
status-firefox28: affected → fixed
status-firefox-esr24: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.