Closed Bug 960088 Opened 7 years ago Closed 7 years ago

Initialize the observer right away in start method in firefox/lib/modal-dialog.js

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 fixed)

RESOLVED FIXED
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed
firefox-esr24 --- fixed

People

(Reporter: cosmin-malutan, Assigned: cosmin-malutan)

References

Details

Attachments

(1 file)

We need to initialize the observer for watching new modalls openings right away in start method without delay as this blocks bug 795398.
Attached patch patch v1.0Splinter Review
Here is the patch for default branch.

The reports from bug 795398, proves it doesn't broke anything.
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8360450 - Flags: review?(andrei.eftimie)
Attachment #8360450 - Flags: review?(andreea.matei)
Patch applies cleanly on all branches.
Comment on attachment 8360450 [details] [diff] [review]
patch v1.0

Review of attachment 8360450 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Make sure it also passes on all branches locally. I can land on default now with an updated commit message.
Attachment #8360450 - Flags: review?(andrei.eftimie)
Attachment #8360450 - Flags: review?(andreea.matei)
Attachment #8360450 - Flags: review+
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.