960103 - JavaScript Warning: "Error in parsing value for 'background'. Declaration dropped." {file: "app://costcontrol.gaiamobile.org/style/views/firsttime.css"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

E/GeckoConsole(  424): [JavaScript Warning: "Error in parsing value for 'background'.  Declaration dropped." {file: "app://costcontrol.gaiamobile.org/style/views/firsttime.css" line: 151 column: 88 source: "    background: url(../images/app/icons/checked.png) content-box right center no-repeat / 1.9rem;"}]

This happens after starting up the emulator, tested with the jb version of the emulator in pvt builds, with timestamp 20140114154437, then launching the Usage app.

Not sure how to move this forward, setting needinfo? from Salvador, the Gaia::Cost Control module owner.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://github.com/mozilla-b2g/gaia/blame/4cc2dcbf9cebf6d4731783626acf57c3e712f479/apps/costcontrol/style/views/firsttime.css#L151

changed / added this line in the commit:

https://github.com/mozilla-b2g/gaia/commit/a051bdffcfa2318289f61bb5e8c92dc4213fdd56

May be related to bug 830644?

Comment 2

[Salvador de la Puente González [:salva]]

Assigning to :mai, in charge of Cost Control fixes. The problem is simple, instead of using:

background: url(../images/app/icons/checked.png) content-box right center no-repeat / 1.9rem;

We should use:

background: background: url(../images/app/icons/checked.png) content-box right center no-repeat;
background-size: 1.9rem;

Comment 3

[Marina Rodríguez [:mai]]

Attachment: Patch v1.0

Changes made and tested.
Regards.

Comment 4

[Jason Smith [:jsmith]]

This is a JS warning with no user impact, so this wouldn't block a release.

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8361638 [details] [review]
Patch v1.0

Nice. Thank you :mai.

Comment 6

[Marina Rodríguez [:mai]]

Master: 7ce6702d7193e60ba683402c0d6464144c88bfbc