96019 - Ensure <radiogroup> and <radio> comply with spec.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

Radio group and radio are fully specified in section 3.8 of the XUL spec now.  
This bug is for you to go through and ensure all the properties mentioned are 
defined and working.  

Note the deprecation of the "checked" property in favor of "selected", the need 
for <radiogroup> to respond to onselect, the default vertical orientation, and 
the ability for radio groups to work without an id (covered in a separate bug).

While doing this, it will probably be useful to construct the radio groups test 
page.  I can get it checked into gila with the other tests.

Comment 1

[Blake Ross]

--> me

Comment 2

[Blake Ross]

Attachment: patch

Comment 3

[Blake Ross]

Attachment: slightly updated

Comment 4

[David Hyatt]

seems like if (i in children && ...) can just be if (...).

what is the bug with onselect again?  you only fire it in the false case.  is
that because it isn't working in the true case?

Comment 5

[Blake Ross]

Attachment: wah

Comment 6

[Joe Hewitt (gone)]

r=hewitt

Comment 7

[[e-mail]]

Attachment: no event.preventBubble()s

Comment 8

[John Gaunt (redfive)]

I apply this patch ( the wah patch ) and with modern I get no radio buttons and
in classic I get radio buttons with no state ( no visible dot in them ). This is
with a tree from today (9/6) with no other changes. 

Is there other files needed to go with this patch? ( like .idl files? )

Comment 9

[Blake Ross]

I forgot to attach the skin css files.

Comment 10

[John Gaunt (redfive)]

so can/will you post them? I need this patch for XUL radio accessibility work.
thnx

Comment 11

[John Gaunt (redfive)]

Hello? Blake, you said you were going to post those files....

Comment 12

[Blake Ross]

Attachment: skins patches

Comment 13

[John Gaunt (redfive)]

Blake: what's up with this one? Is this complete? I need this stuff in the tree
to land my patches. The patch has been in the bug for over a month now with no
more progress.

Comment 14

[Blake Ross]

There has been plenty of progress on my end.  Many other changes are landing
with this one.  I'm finishing them up.  Landing very very soon.

Comment 15

[Blake Ross]

Fixed.