Closed Bug 960217 Opened 8 years ago Closed 8 years ago

Change Reader Mode "share" icon to be consistent with other share icons

Categories

(Firefox for Android Graveyard :: Reader View, defect)

x86
Android
defect
Not set
normal

Tracking

(fennec28+)

RESOLVED FIXED
Firefox 29
Tracking Status
fennec 28+ ---

People

(Reporter: deb, Assigned: oogunsakin)

References

Details

Attachments

(1 file)

The reader mode share icon is still an airplane while the share icon is the three-connected-dots thing everywhere else.

This got missed in a previous bug (see Comment #1 in bug 940997).
tracking-fennec: --- → ?
Blocks: readerv2
Ian, sounds like we need a graphic
Assignee: nobody → oogunsakin
tracking-fennec: ? → 28+
Flags: needinfo?(ibarlow)
Attached patch PatchSplinter Review
Ian sent me new icons. I'll have him look and sign off on my phone.
Attachment #8366727 - Flags: review?(lucasr.at.mozilla)
Flags: needinfo?(ibarlow)
Comment on attachment 8366727 [details] [diff] [review]
Patch

Review of attachment 8366727 [details] [diff] [review]:
-----------------------------------------------------------------

> p@b;9kuqZUFp7&%7LFZVi8*M

Are you sure this is working fine? :-)
Attachment #8366727 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c7b400933685
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Verified fixed on:
Buid: Firefox for Android 29.0a1 (2014-02-03)
Device: Samsung Galaxy Nexus (Android 4.3)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.