96029 - The Save-As dialog was displayed for a text/html page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[rpotts (gone)]

I've hit another edge case where the save-as dialog appears for a HTML page...

This time, i was hitting back and forward (between www.mozilla.org and
www.cnn.com) trying to reproduce another bug :-)  After a while, I got an
ASSERTION in nsDSURIContentListener that mDocShell was NULL.  After continuing,
the save-as dialog appeared :-(

Here's what happened:
If nsIURIContentListener::DoContent(...) fails the URI load *does not* fail... 
Instead it drops down into the save-as code :-(  This seems wrong.

Comment 1

[rpotts (gone)]

Attachment: Here's a patch that fixes the situation...

Comment 2

[rpotts (gone)]

hey scott,

does this patch make sense... or was there a reason that the status code from
DoContent was ignored?

-- rick

Comment 3

[rpotts (gone)]

is this related to (or a dup of) bug #81576?

Comment 4

[Scott MacGregor]

looks okay to me rick. r/sr=mscott

Comment 5

[rpotts (gone)]

adam, jud,

can i get a quick review so i can check this one in?

thanks,
-- rick

Comment 6

[Judson Valeski]

r=valeski

Comment 7

[rpotts (gone)]

patch check in...

Comment 8

[Tom Mraz]

The fix caused serious regression. See bug 96418

Comment 9

[rpotts (gone)]

I'm closing this out again because bug #96418 covers the regression that was
introduced...