960333 - [User story] Create a ringtone from an audio file downloaded from the browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Comment 1

[Jim Porter (:squib)]

My understanding is that this is already done, but I don't know how to make things show up in the download manager to test this. David: I recall you reviewed the patch that I'm thinking of; do you know anything about this?

Comment 2

[David Flanagan [:djf]]

Jim,

I thought the download manager was a separate app, and I remember reviewing, or at least discussing, code that allowed it to trigger a share activity.  Now, however, it appears that the download manager is in the system and settings apps.  Maybe our share requirement has been dropped in the change?  Most of the download manager checkins are from TEF developers apparently.

Sorry I don't know any more about this

Comment 3

[Jim Porter (:squib)]

Gregor: Hema tells me you might know about this. Has this already been completed by the Download Manager folks, and if not, how do I get something to show up in the download manager? The last time I tried, I couldn't figure out how to do that.

Comment 4

[Gregor Wagner [:gwagner]]

Tef did a lot of the front-end work. You might want to ping francisco or borja.
Aus knows the back-end implementation.

Comment 5

[Hema Koka [:hema]]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> Tef did a lot of the front-end work. You might want to ping francisco or
> borja.
> Aus knows the back-end implementation.

NI Francisco...see jim's comment1/3 on how to test this case out - help is appreciated!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

(In reply to David Flanagan [:djf] from comment #2)
> Jim,
> 
> I thought the download manager was a separate app, and I remember reviewing,
> or at least discussing, code that allowed it to trigger a share activity. 
> Now, however, it appears that the download manager is in the system and
> settings apps.  Maybe our share requirement has been dropped in the change? 
> Most of the download manager checkins are from TEF developers apparently.
> 
> Sorry I don't know any more about this

David you are totally right, there is a share activity, despite that download manager lives between the system app (for notifications) and settings (for managing). We decided to implement the sharing via web activities to make it as compatible with other apps as possible.

Right now we do have a share activity to setup the rign tone, I was just trying it and saw the following:

E/GeckoConsole(  861): [JavaScript Error: "TypeError: storage is null" {file: "app://settings.gaiamobile.org/shared/js/download/download_helper.js" line: 117}]

Will open a bug to block this user story.

Thanks everyone.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi, now that I've tried on a newer build, and now that I can interact with downloads, I just downloaded a mp3, went to the downloads list on settings and click on it, then shared and there it is on the ringtones list.

Do we need a QA round to verify this functionality is already there?

Cheers,
F.

Comment 8

[Aus Lacroix [:aus]]

Could we re-test with the latest build and get this story verified?

Comment 9

[Joshua Mitchell (Inactive)]

I've tested on the latest Open_C build and can verify Francisco's findings; Selecting the MP3 in the downloads menu brings up a Set as Ringtone option AND a share option where "Set Ringtone" is one of the "share with:" options as well.

Environmental Variables:

Device: Open_C 2.0
BuildID: 20140528043007
Gaia: bc6f07c149770c6e6dfbea941ac65138dc364a15
Gecko: e017c15325ae
Version: 32.0a1
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 10

[Jim Porter (:squib)]

Ok, this works. It turns out the issue is that I had to force the song to have a Content-Disposition of attachment, since there seems to be no way to download a song from the in-browser music player UI.

Comment 11

[Jim Porter (:squib)]

I believe this has worked for a while, but I'm sure it works with the new ringtones app, so -> FIXED.