Closed
Bug 960341
Opened 12 years ago
Closed 12 years ago
Add SVG support to image uploader
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brett, Assigned: jon)
References
Details
Attachments
(1 external file)
We support SVGs (as evidenced by the default image) but not in the uploader. Let's fix!
Also from bug #955611
|
||
Comment 1•12 years ago
|
||
SVGs are active content, unlike images - i.e. AIUI they can potentially contain script. It may be OK if you reference them via an <img> tag rather than inlining them, but you should check with an expert. Putting them on a different domain (origin) might also be a wise move.
Gerv
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8389233 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/497
Wow, that was it?
Attachment #8389233 -
Flags: review?(scott) → review+
|
||
Comment 4•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/04e56b4bb401d4aff02ed432e5f801e4f1032037
Fix bug 960341 - Support SVG image uploads
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•12 years ago
|
||
Yep, that was it :)
You need to log in
before you can comment on or make changes to this bug.
Description
•