960351 - browser_bug726427_csstransform_tooltip.js | Test timed out

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip

https://tbpl.mozilla.org/php/getParsedLog.php?id=33046746&full=1&branch=mozilla-inbound#error0

This seems to happen randomly with bug 930793, which changes how often we run gecko
events comparing to native os level events in the main loop.

I can't reproduce the issue locally. Guess fix based on 
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/tests/widgets/popup_shared.js#213

https://tbpl.mozilla.org/?tree=Try&rev=d6635ca9ac05

Comment 1

[Patrick Brosset <:pbro>]

Comment on attachment 8360777 [details] [diff] [review]
wip

Review of attachment 8360777 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/test/browser_bug726427_csstransform_tooltip.js
@@ +151,5 @@
> +  // Run _showOnHover at stable state after the next refresh driver tick.
> +  element.ownerDocument.defaultView.requestAnimationFrame(
> +    function() {
> +      setTimeout(function() { tooltip._showOnHover(element); }, 0);
> +    });

This looks weird at first, but after a discussion on IRC, it seems popup event handling is sometimes a problem that can be fixed with this kind of things.
Some events are dispatched asynchronously, some synchronously, some based on paint event, ...

Since the try build seems to confirm that it fixes this issue, let's go with this fix, but I'd like to ask for a couple of changes:

- A bit more comments to inform what's the exact reason for this fix.
- Use of executeSoon and arrow functions:

element.ownerDocument.defaultView.requestAnimationFrame(() => {
  executeSoon(() => tooltip._showOnHover(element));
});

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=7183177b40dc
should give still some more debug information.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

https://tbpl.mozilla.org/?tree=Try&rev=195e2e509381

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92f64142decc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/92f64142decc

Comment 6

[Patrick Brosset <:pbro>]

Bug 961004 is a new intermittent that just appeared after this fix it seems.
We might want to revisit this.