Closed Bug 960366 Opened 11 years ago Closed 11 years ago

OpenH264: crash [@WelsDec::BsGetBits]

Categories

(Core :: WebRTC: Audio/Video, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: posidron, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase)

Attachments

(2 files)

Attached video aac-sample.mp4
Hi Christoph, is there any pure 264 file besides mp4 file?
No, it seems only to crash with mp4 files.
We've found the root cause, i.e., missing the process of empty data packet. We'll discuss and have a solution for it in one or two days.
Root cause found, empty non-vcl packet missing size check. Fixed(review request #44). pull request can be seen via: https://github.com/cisco/openh264/pull/153
Hi Christoph: fix it. Could you verify it on cisco/master branch? thanks!
I get "No input file specified in configuration file." but no crash. Fixed. Tested with https://github.com/cisco/openh264/commit/fcd7a13816
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hi Christoph, you need to modify the suffix ".mp4" as ".264", then the decoder would work. It is the test APP constraint to recognize only ".264".
Tested again - no crash.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: