960529 - Avoid extra updateDisplayLayout() call in BrowserToolbar.refreshState()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

We should avoid extra work, especially during pageload.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Centralize private mode setting into the proper method (r=bnicholson)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Avoid redudant updateDisplayLayout() call (r=bnicholson)

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Simplify switch block for TabEvents in BrowserToolbar (r=bnicholson)

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8363020 [details] [diff] [review]
Simplify switch block for TabEvents in BrowserToolbar (r=bnicholson)

Review of attachment 8363020 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/3b6044c59b6d
https://hg.mozilla.org/integration/fx-team/rev/6d11825bf746
https://hg.mozilla.org/integration/fx-team/rev/80762d4915d5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b6044c59b6d
https://hg.mozilla.org/mozilla-central/rev/6d11825bf746
https://hg.mozilla.org/mozilla-central/rev/80762d4915d5