960618 - BOM in manifest treated as invalid

Status: RESOLVED FIXED

(Marketplace Graveyard :: Integration, defect, P1)

Description

[Austin King [:ozten]]

The APK Factory Service will reject manifests which have a BOM marker.

Steps to reproduce:
1) curl -v 'http://dapk.net/application.apk?manifestUrl=http://pacman.platzh1rsch.ch/pacman-canvas.webapp

Actual:
SyntaxError: Unexpected token

Expected:
A valid APK

Comment 1

[Austin King [:ozten]]

Actual contents of the manifest:

    <U+FEFF>{
      "name": "Pacman Canvas (Beta)",
      "description": "An old classic, rewritten in HTML5",
      "launch_path": "/",
      "developer": {
        "name": "platzh1rsch",
        "url": "http://platzh1rsch.ch"
      },
      "icons": {
            "128": "/img/icon-128.png"
            },
      "default_locale": "en"
    }

Comment 2

[Austin King [:ozten]]

Kumar notes how this is handled in the Marketplace
https://github.com/mozilla/zamboni/blob/master/apps/amo/utils.py#L948

Comment 3

[Kumar McMillan [:kumar]]

Attachment: pacman-canvas.webapp

manifest, in case it goes offline or changes

Comment 4

[Austin King [:ozten]]

ETA - We are live in nightly, so I'd like to fix this. Happy to grab this, if you're heads down in other bugs.

Comment 5

[Kumar McMillan [:kumar]]

yeah, this is important. We are live as in real users are requesting real APKs?

Comment 6

[Austin King [:ozten]]

Fixed in https://github.com/mozilla/apk-factory-service/pull/36