960653 - shrink JSJitInfo.{protoID,depth} fields

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - assert that we don't overflow JSJitInfo fields in bindings codegen

Technically, I think that narrowing warnings in GCC/Clang (MSVC?) would catch
this too, but this is a more robust solution that doesn't rely on faraway
warning flags in the build system.

The uint64_t cast is to make this compile with the current uint32_t field
definitions; the shift would be undefined if the |1| was of type int.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - change JSJitInfo.{protoID,depth} to 16-bit fields

Trivial change which buys us another four bytes.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8361203 [details] [diff] [review]
part 1 - assert that we don't overflow JSJitInfo fields in bindings codegen

r=me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8361205 [details] [diff] [review]
part 2 - change JSJitInfo.{protoID,depth} to 16-bit fields

r=me, fwiw.  Feel free to just go with it.

Comment 5

[Eric Faust [:efaust]]

Comment on attachment 8361205 [details] [diff] [review]
part 2 - change JSJitInfo.{protoID,depth} to 16-bit fields

Review of attachment 8361205 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this should be fine. r=me

Comment 6

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2da6a47736c5
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7079694645

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2da6a47736c5
https://hg.mozilla.org/mozilla-central/rev/4b7079694645